linux-kernel - Re: [PATCH] checkpatch: add new exception to repeated word check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABJPP5Cp7LNJhhNTtpoHidZEO1nXWL-+ZWijvOJ9EVQ4_cK_ng@mail.gmail.com>
Date:   Wed, 14 Oct 2020 22:03:35 +0530
From:   Dwaipayan Ray <dwaipayanray1@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     linux-kernel-mentees@...ts.linuxfoundation.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>
Subject: Re: [PATCH] checkpatch: add new exception to repeated word check

On Wed, Oct 14, 2020 at 9:47 PM Joe Perches <joe@...ches.com> wrote:
>
> On Wed, 2020-10-14 at 19:26 +0530, Dwaipayan Ray wrote:
> > Recently, commit 4f6ad8aa1eac ("checkpatch: move repeated word test")
> > moved the repeated word test to check for more file types. But after
> > this, if checkpatch.pl is run on MAINTAINERS, it generates several
> > new warnings of the type:
> >
> > WARNING: Possible repeated word: 'git'
> []
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
> > @@ -3063,7 +3063,7 @@ sub process {
> >                               }
> >
> >                               next if ($first ne $second);
> > -                             next if ($first eq 'long');
> > +                             next if ($first =~ /(?:long|git)$/);
>
> Nak.  This needs a leading ^ otherwise words
> like "belong" and "digit" match as well.
>
>                                 next if ($first =~ /^(?:long|git)$/);
>
>

Yikes, that was silly of me. I will correct and send you the
updated version.

Thanks,
Dwaipayan.