linux-kernel - Re: [PATCH 3/3] mfd: ahc1ec0-wdt: Add sub-device watchdog for Advantech embedded controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202010150122.tmDHIzQO-lkp@intel.com>
Date:   Thu, 15 Oct 2020 01:23:51 +0800
From:   kernel test robot <lkp@...el.com>
To:     Shihlun Lin <shihlun.lin@...antech.com.tw>,
        Lee Jones <lee.jones@...aro.org>, linux-kernel@...r.kernel.org,
        Campion Kang <campion.kang@...antech.com.tw>,
        AceLan Kao <chia-lin.kao@...onical.com>
Cc:     kbuild-all@...ts.01.org
Subject: Re: [PATCH 3/3] mfd: ahc1ec0-wdt: Add sub-device watchdog for
 Advantech embedded controller

Hi Shihlun,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on linux/master v5.9]
[cannot apply to lee-mfd/for-mfd-next next-20201013]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Shihlun-Lin/mfd-ahc1ec0-Add-support-for-Advantech-embedded-controller/20201014-164627
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git b5fc7a89e58bcc059a3d5e4db79c481fb437de59
config: parisc-randconfig-r003-20201014 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/c0d1228cbc430e5be6ac8a311f8fa783f9285628
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Shihlun-Lin/mfd-ahc1ec0-Add-support-for-Advantech-embedded-controller/20201014-164627
        git checkout c0d1228cbc430e5be6ac8a311f8fa783f9285628
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/mfd/ahc1ec0-wdt.c: In function 'wdt_proc_read':
>> drivers/mfd/ahc1ec0-wdt.c:162:17: warning: variable 'name' set but not used [-Wunused-but-set-variable]
     162 |  unsigned char *name, *chip_name, *is_enable;
         |                 ^~~~
   drivers/mfd/ahc1ec0-wdt.c: In function 'adv_ec_wdt_probe':
>> drivers/mfd/ahc1ec0-wdt.c:426:31: warning: variable 'adv_ec_data' set but not used [-Wunused-but-set-variable]
     426 |  struct adv_ec_platform_data *adv_ec_data;
         |                               ^~~~~~~~~~~

vim +/name +162 drivers/mfd/ahc1ec0-wdt.c

   159	
   160	static int wdt_proc_read(struct seq_file *m, void *p)
   161	{
 > 162		unsigned char *name, *chip_name, *is_enable;
   163		unsigned long current_timeout = 0;
   164	
   165		name = m->private;
   166	
   167		chip_name = wdt_data.chip_name;
   168		current_timeout = wdt_data.current_timeout;
   169		is_enable = wdt_data.is_enable;
   170	
   171		seq_printf(m, "name       : %s\n", chip_name);
   172		seq_printf(m, "timeout    : %ld\n", current_timeout);
   173		seq_printf(m, "is_enable  : %s\n", is_enable);
   174	
   175		return 0;
   176	}
   177	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (25598 bytes)