linux-kernel - Re: [PATCH 2/2] clk: samsung: exynos-clkout: convert to module driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <160264342071.310579.16332243912081691987@swboyd.mtv.corp.google.com>
Date:   Tue, 13 Oct 2020 19:43:40 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Chanwoo Choi <cw00.choi@...sung.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Kukjin Kim <kgene@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Sylwester Nawrocki <s.nawrocki@...sung.com>,
        Tomasz Figa <tomasz.figa@...il.com>,
        linux-arm-kernel@...ts.infradead.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org
Cc:     Marek Szyprowski <m.szyprowski@...sung.com>
Subject: Re: [PATCH 2/2] clk: samsung: exynos-clkout: convert to module driver

Quoting Krzysztof Kozlowski (2020-10-01 09:56:46)
> diff --git a/drivers/clk/samsung/clk-exynos-clkout.c b/drivers/clk/samsung/clk-exynos-clkout.c
> index 34ccb1d23bc3..68af082d4716 100644
> --- a/drivers/clk/samsung/clk-exynos-clkout.c
> +++ b/drivers/clk/samsung/clk-exynos-clkout.c
> @@ -28,41 +31,103 @@ struct exynos_clkout {
[...]
> +       if (!match) {
> +               dev_err(dev, "cannot match parent device\n");
> +               return -EINVAL;
> +       }
> +       variant = match->data;
> +
> +       *mux_mask = variant->mux_mask;
> +       dev_err(dev, "MATCH: %x\n", variant->mux_mask);

Is this a debug print?

> +
> +       return 0;
> +}
>