linux-kernel - Re: [PATCH] checkpatch: add a fixer for missing newline at eof

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7983b5dcb7f589e31fb954cfc1472a93244984fb.camel@perches.com>
Date:   Wed, 14 Oct 2020 17:42:40 -0700
From:   Joe Perches <joe@...ches.com>
To:     trix@...hat.com, apw@...onical.com
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: add a fixer for missing newline at eof

On Wed, 2020-10-14 at 14:15 -0700, trix@...hat.com wrote:
> From: Tom Rix <trix@...hat.com>
> 
> Remove the trailing error message from the fixed lines

Hi Tom.

> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -3393,8 +3393,11 @@ sub process {
>  
>  # check for adding lines without a newline.
>  		if ($line =~ /^\+/ && defined $lines[$linenr] && $lines[$linenr] =~ /^\\ No newline at end of file/) {
> -			WARN("MISSING_EOF_NEWLINE",
> -			     "adding a line without newline at end of file\n" . $herecurr);
> +			if (WARN("MISSING_EOF_NEWLINE",
> +			         "adding a line without newline at end of file\n" . $herecurr) &&
> +			    $fix) {
> +			    fix_delete_line($fixlinenr+1, "No newline at end of file");

This is misindented, the 4 spaces before fix_delete_line
should be a tab, otherwise this looks fine, thanks.