linux-kernel - RE: [PATCH] opp: Don't always remove static OPPs in _of_add_opp_table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 15 Oct 2020 02:35:35 +0000
From:   Aisheng Dong <aisheng.dong@....com>
To:     Viresh Kumar <viresh.kumar@...aro.org>,
        Rafael Wysocki <rjw@...ysocki.net>,
        Viresh Kumar <vireshk@...nel.org>, Nishanth Menon <nm@...com>,
        Stephen Boyd <sboyd@...nel.org>
CC:     "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: RE: [PATCH] opp: Don't always remove static OPPs in
 _of_add_opp_table_v1()

Hi Viresh

Thanks for the quick fix.

> From: Viresh Kumar <viresh.kumar@...aro.org>
> Sent: Wednesday, October 14, 2020 12:26 PM
> 
> The patch missed returning 0 early in case of success and hence the static OPPs
> got removed by mistake. Fix it.
> 
> Fixes: 90d46d71cce2 ("opp: Handle multiple calls for same OPP table in
> _of_add_opp_table_v1()")
> Reported-by: Aisheng Dong <aisheng.dong@....com>
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>

Tested-by: Dong Aisheng <aisheng.dong@....com>

Regards
Aisheng

> ---
>  drivers/opp/of.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/opp/of.c b/drivers/opp/of.c index
> 874b58756220..9faeb83e4b32 100644
> --- a/drivers/opp/of.c
> +++ b/drivers/opp/of.c
> @@ -944,6 +944,8 @@ static int _of_add_opp_table_v1(struct device *dev,
> struct opp_table *opp_table)
>  		nr -= 2;
>  	}
> 
> +	return 0;
> +
>  remove_static_opp:
>  	_opp_remove_all_static(opp_table);
> 
> --
> 2.25.0.rc1.19.g042ed3e048af