linux-kernel - Re: [PATCH 6/6] dt-bindings: misc: correct the property name cmd-gpios to cmd-gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201015071256.GA1092695@demiurge.local>
Date:   Thu, 15 Oct 2020 09:12:56 +0200
From:   Lubomir Rintel <lkundrak@...sk>
To:     Zhen Lei <thunder.leizhen@...wei.com>
Cc:     Rob Herring <robh+dt@...nel.org>, Pavel Machek <pavel@....cz>,
        Dan Murphy <dmurphy@...com>,
        linux-leds <linux-leds@...r.kernel.org>,
        Lee Jones <lee.jones@...aro.org>,
        Benson Leung <bleung@...omium.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Guenter Roeck <groeck@...omium.org>,
        Mark Brown <broonie@...nel.org>,
        linux-spi <linux-spi@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 6/6] dt-bindings: misc: correct the property name
 cmd-gpios to cmd-gpio

Hi,

On Wed, Oct 14, 2020 at 12:08:45AM +0800, Zhen Lei wrote:
> The property name used in arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts is
> cmd-gpio.
> 
> arch/arm/boot/dts/mmp2-olpc-xo-1-75.dts:235:
> cmd-gpio = <&gpio 155 GPIO_ACTIVE_HIGH>;
> 
> Signed-off-by: Zhen Lei <thunder.leizhen@...wei.com>

Thanks for the patch.

I've sent out an equivalent one some time ago:
https://lore.kernel.org/lkml/20200925234805.228251-3-lkundrak@v3.sk/

In any case, either is fine with me.

Acked-by: Lubomir Rintel <lkundrak@...sk>

> ---
>  Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml b/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml
> index b3c45c046ba5e37..c7a06a9650db2ed 100644
> --- a/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml
> +++ b/Documentation/devicetree/bindings/misc/olpc,xo1.75-ec.yaml
> @@ -24,7 +24,7 @@ properties:
>    compatible:
>      const: olpc,xo1.75-ec
>  
> -  cmd-gpios:
> +  cmd-gpio:
>      description: GPIO uspecifier of the CMD pin
>      maxItems: 1
>  
> @@ -32,7 +32,7 @@ properties:
>  
>  required:
>    - compatible
> -  - cmd-gpios
> +  - cmd-gpio
>  
>  additionalProperties: false
>  
> @@ -49,7 +49,7 @@ examples:
>        slave {
>          compatible = "olpc,xo1.75-ec";
>          spi-cpha;
> -        cmd-gpios = <&gpio 155 GPIO_ACTIVE_HIGH>;
> +        cmd-gpio = <&gpio 155 GPIO_ACTIVE_HIGH>;
>        };
>      };
>  
> -- 
> 1.8.3
> 
>