linux-kernel - Re: [PATCH 4/6] clk: renesas: r8a779a0: Add VIN[00-31] clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f75c5be2-ef40-bd08-dc0b-b025045b15d4@gmail.com>
Date:   Thu, 15 Oct 2020 11:00:04 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...il.com>
To:     Jacopo Mondi <jacopo@...ndi.org>
Cc:     Jacopo Mondi <jacopo+renesas@...ndi.org>,
        linux-renesas-soc@...r.kernel.org, geert+renesas@...der.be,
        laurent.pinchart@...asonboard.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/6] clk: renesas: r8a779a0: Add VIN[00-31] clocks

Hello!

On 15.10.2020 12:32, Jacopo Mondi wrote:

[...]
>>> Add clock definitions of the VIN instances for R-Car V3U.
>>>
>>> Signed-off-by: Jacopo Mondi <jacopo+renesas@...ndi.org>
>>>
>>> ---
>>> Clocks at indexes 730 and 731 are named 'vin0' and 'vin1'.
>>> I assumed it's a typographic error and renamed them 'vin00' and 'vin01'
>>> ---
>>>   drivers/clk/renesas/r8a779a0-cpg-mssr.c | 32 +++++++++++++++++++++++++
>>>   1 file changed, 32 insertions(+)
>>>
>>> diff --git a/drivers/clk/renesas/r8a779a0-cpg-mssr.c b/drivers/clk/renesas/r8a779a0-cpg-mssr.c
>>> index bd54a28c50ee..2a00eb82013f 100644
>>> --- a/drivers/clk/renesas/r8a779a0-cpg-mssr.c
>>> +++ b/drivers/clk/renesas/r8a779a0-cpg-mssr.c
>>> @@ -149,6 +149,38 @@ static const struct mssr_mod_clk r8a779a0_mod_clks[] __initconst = {
>>>   	DEF_MOD("scif1",	703,	R8A779A0_CLK_S1D8),
>>>   	DEF_MOD("scif3",	704,	R8A779A0_CLK_S1D8),
>>>   	DEF_MOD("scif4",	705,	R8A779A0_CLK_S1D8),
>>> +	DEF_MOD("vin00",	730,	R8A779A0_CLK_S1D1),
>>> +	DEF_MOD("vin01",	731,	R8A779A0_CLK_S1D1),
>>> +	DEF_MOD("vin02",	800,	R8A779A0_CLK_S1D1),
>>> +	DEF_MOD("vin03",	801,	R8A779A0_CLK_S1D1),
>>> +	DEF_MOD("vin04",	802,	R8A779A0_CLK_S1D1),
>>> +	DEF_MOD("vin05",	803,	R8A779A0_CLK_S1D1),
>>> +	DEF_MOD("vin06",	804,	R8A779A0_CLK_S1D1),
>>> +	DEF_MOD("vin07",	805,	R8A779A0_CLK_S1D1),
>>> +	DEF_MOD("vin10",	806,	R8A779A0_CLK_S1D1),
>>> +	DEF_MOD("vin11",	807,	R8A779A0_CLK_S1D1),
>>> +	DEF_MOD("vin12",	808,	R8A779A0_CLK_S1D1),
>>> +	DEF_MOD("vin13",	809,	R8A779A0_CLK_S1D1),
>>> +	DEF_MOD("vin14",	810,	R8A779A0_CLK_S1D1),
>>> +	DEF_MOD("vin15",	811,	R8A779A0_CLK_S1D1),
>>> +	DEF_MOD("vin16",	812,	R8A779A0_CLK_S1D1),
>>> +	DEF_MOD("vin17",	813,	R8A779A0_CLK_S1D1),
>>> +	DEF_MOD("vin20",	814,	R8A779A0_CLK_S1D1),
>>> +	DEF_MOD("vin21",	815,	R8A779A0_CLK_S1D1),
>>> +	DEF_MOD("vin22",	816,	R8A779A0_CLK_S1D1),
>>> +	DEF_MOD("vin23",	817,	R8A779A0_CLK_S1D1),
>>> +	DEF_MOD("vin24",	818,	R8A779A0_CLK_S1D1),
>>> +	DEF_MOD("vin25",	819,	R8A779A0_CLK_S1D1),
>>> +	DEF_MOD("vin26",	820,	R8A779A0_CLK_S1D1),
>>> +	DEF_MOD("vin27",	821,	R8A779A0_CLK_S1D1),
>>> +	DEF_MOD("vin30",	822,	R8A779A0_CLK_S1D1),
>>> +	DEF_MOD("vin31",	823,	R8A779A0_CLK_S1D1),
>>> +	DEF_MOD("vin32",	824,	R8A779A0_CLK_S1D1),
>>> +	DEF_MOD("vin33",	825,	R8A779A0_CLK_S1D1),
>>> +	DEF_MOD("vin34",	826,	R8A779A0_CLK_S1D1),
>>> +	DEF_MOD("vin35",	827,	R8A779A0_CLK_S1D1),
>>> +	DEF_MOD("vin36",	828,	R8A779A0_CLK_S1D1),
>>> +	DEF_MOD("vin37",	829,	R8A779A0_CLK_S1D1),
> 
> There are 32 VIN instances (hence the [0-31] in the subject), grouped
> in 4 units of 8 channels each.
> 
> I can drop the [0-31] in the subject if it's confusing.

    Please do. :-)

>>     The subject says VIN[0-31]?
>>
>> [...]

MBR, Sergei