linux-kernel - Re: [PATCH v1 08/29] virtio-mem: drop last_mb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201015083519.GG86495@L-31X9LVDL-1304.local>
Date:   Thu, 15 Oct 2020 16:35:19 +0800
From:   Wei Yang <richard.weiyang@...ux.alibaba.com>
To:     David Hildenbrand <david@...hat.com>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        virtualization@...ts.linux-foundation.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        "Michael S . Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        Pankaj Gupta <pankaj.gupta.linux@...il.com>
Subject: Re: [PATCH v1 08/29] virtio-mem: drop last_mb_id

On Mon, Oct 12, 2020 at 02:53:02PM +0200, David Hildenbrand wrote:
>No longer used, let's drop it.
>
>Cc: "Michael S. Tsirkin" <mst@...hat.com>
>Cc: Jason Wang <jasowang@...hat.com>
>Cc: Pankaj Gupta <pankaj.gupta.linux@...il.com>
>Signed-off-by: David Hildenbrand <david@...hat.com>

If above two patches are merged.

Reviewed-by: Wei Yang <richard.weiyang@...ux.alibaba.com>

>---
> drivers/virtio/virtio_mem.c | 4 ----
> 1 file changed, 4 deletions(-)
>
>diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
>index 37a0e338ae4a..5c93f8a65eba 100644
>--- a/drivers/virtio/virtio_mem.c
>+++ b/drivers/virtio/virtio_mem.c
>@@ -84,8 +84,6 @@ struct virtio_mem {
> 
> 	/* Id of the first memory block of this device. */
> 	unsigned long first_mb_id;
>-	/* Id of the last memory block of this device. */
>-	unsigned long last_mb_id;
> 	/* Id of the last usable memory block of this device. */
> 	unsigned long last_usable_mb_id;
> 	/* Id of the next memory bock to prepare when needed. */
>@@ -1689,8 +1687,6 @@ static int virtio_mem_init(struct virtio_mem *vm)
> 	vm->first_mb_id = virtio_mem_phys_to_mb_id(vm->addr - 1 +
> 						   memory_block_size_bytes());
> 	vm->next_mb_id = vm->first_mb_id;
>-	vm->last_mb_id = virtio_mem_phys_to_mb_id(vm->addr +
>-			 vm->region_size) - 1;
> 
> 	dev_info(&vm->vdev->dev, "start address: 0x%llx", vm->addr);
> 	dev_info(&vm->vdev->dev, "region size: 0x%llx", vm->region_size);
>-- 
>2.26.2

-- 
Wei Yang
Help you, Help me