linux-kernel - Re: [PATCH 2/2] xen: Kconfig: nest Xen guest options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d8a8ed95-ed55-4ccf-1b54-8d97db908742@suse.com>
Date:   Thu, 15 Oct 2020 11:41:58 +0200
From:   Jürgen Groß <jgross@...e.com>
To:     Jason Andryuk <jandryuk@...il.com>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Stefano Stabellini <sstabellini@...nel.org>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        x86@...nel.org, "H. Peter Anvin" <hpa@...or.com>,
        xen-devel@...ts.xenproject.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] xen: Kconfig: nest Xen guest options

On 14.10.20 19:53, Jason Andryuk wrote:
> Moving XEN_512GB allows it to nest under XEN_PV.  That also allows
> XEN_PVH to nest under XEN as a sibling to XEN_PV and XEN_PVHVM giving:
> 
> [*]   Xen guest support
> [*]     Xen PV guest support
> [*]       Limit Xen pv-domain memory to 512GB
> [*]       Xen PV Dom0 support

This has currently a wrong text/semantics:

It should be split to CONFIG_XEN_DOM0 and CONFIG_XEN_PV_DOM0.

Otherwise the backends won't be enabled per default for a PVH-only
config meant to be Dom0-capable.

You don't have to do that in your patches if you don't want to, but
I wanted to mention it with you touching this area of Kconfig.

> [*]     Xen PVHVM guest support
> [*]     Xen PVH guest support
> 
> Signed-off-by: Jason Andryuk <jandryuk@...il.com>

Reviewed-by: Juergen Gross <jgross@...e.com>


Juergen