linux-kernel - Re: [PATCH v2] lib: kunit: add list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201015105105.GS4077@smile.fi.intel.com>
Date:   Thu, 15 Oct 2020 13:51:05 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Vitor Massaru Iha <vitor@...saru.org>
Cc:     kunit-dev@...glegroups.com, brendanhiggins@...gle.com,
        elver@...gle.com, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org, skhan@...uxfoundation.org,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        gregkh@...uxfoundation.org, tglx@...utronix.de,
        geert@...ux-m68k.org, paul.gortmaker@...driver.com,
        akpm@...ux-foundation.org, torvalds@...ux-foundation.org,
        arnd@...db.de, elfring@...rs.sourceforge.net, mhocko@...e.com
Subject: Re: [PATCH v2] lib: kunit: add list_sort test conversion to KUnit

On Wed, Oct 14, 2020 at 10:46:16PM -0300, Vitor Massaru Iha wrote:
> This adds the conversion of the runtime tests of test_list_sort,
> from `lib/test_list_sort.c` to KUnit tests.

Please, provide better commit message. For example, add the output of _succeeded_
*and* _failed_ test cases (yes, you have to break code manually to reproduce failed
test cases) _before_ *and* _after_ the change.

W/o above information I'm going to NAK this as I promised before.

-- 
With Best Regards,
Andy Shevchenko