linux-kernel - Re: [PATCH 0/8] remove never-used "snps,dw-apb-gpio-port"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201015114022.7ptrl37g5d3lumyw@mobilestation>
Date:   Thu, 15 Oct 2020 14:40:22 +0300
From:   Serge Semin <fancer.lancer@...il.com>
To:     Jisheng Zhang <Jisheng.Zhang@...aptics.com>
Cc:     Hoan Tran <hoan@...amperecomputing.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Rob Herring <robh+dt@...nel.org>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        Dinh Nguyen <dinguyen@...nel.org>,
        Khuong Dinh <khuong@...amperecomputing.com>,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        Wei Xu <xuwei5@...ilicon.com>, linux-gpio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 0/8] remove never-used "snps,dw-apb-gpio-port"

Hello Jisheng,

Thanks for sending this cleanup and for the work you've done in its framework.
The compatible property is indeed redundant in the DW APB GPIO bindings, because
any sub-node is considered as one of the device port from the set {A,B,C,D} and I
don't see why would we need to be there for anything else. The port index is
initialized by the reg property, which I've just realized lack of a proper
constraints.

Anyway see my comment to the DT binding file. The rest of the series is up to
the corresponding subsystem maintainers.

-Sergey

On Thu, Oct 15, 2020 at 11:55:24AM +0800, Jisheng Zhang wrote:
> The "snps,dw-apb-gpio-port" is never used.
> 
> Jisheng Zhang (8):
>   ARM: dts: berlin: Remove compatible string from dw apb gpio port
>   ARM: dts: socfpga: Remove compatible string from dw apb gpio port
>   arm64: dts: apm: remove compatible string from dw apb gpio port
>   arm64: dts: bitmain: Remove compatible string from dw apb gpio port
>   arm64: dts: hip05: Remove compatible string from dw apb gpio port
>   arm: dts: socfpga: Remove compatible string from dw apb gpio port
>   arm64: dts: synaptics: Remove compatible string from dw apb gpio port
>   dt-bindings: gpio: dw-apb: remove never-used "snps,dw-apb-gpio-port"
> 
>  .../devicetree/bindings/gpio/snps,dw-apb-gpio.yaml          | 5 -----
>  arch/arm/boot/dts/berlin2.dtsi                              | 6 ------
>  arch/arm/boot/dts/berlin2cd.dtsi                            | 6 ------
>  arch/arm/boot/dts/berlin2q.dtsi                             | 6 ------
>  arch/arm/boot/dts/socfpga.dtsi                              | 3 ---
>  arch/arm/boot/dts/socfpga_arria10.dtsi                      | 3 ---
>  arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi           | 2 --
>  arch/arm64/boot/dts/apm/apm-shadowcat.dtsi                  | 1 -
>  arch/arm64/boot/dts/apm/apm-storm.dtsi                      | 1 -
>  arch/arm64/boot/dts/bitmain/bm1880.dtsi                     | 3 ---
>  arch/arm64/boot/dts/hisilicon/hip05.dtsi                    | 2 --
>  arch/arm64/boot/dts/intel/socfpga_agilex.dtsi               | 2 --
>  arch/arm64/boot/dts/synaptics/as370.dtsi                    | 2 --
>  arch/arm64/boot/dts/synaptics/berlin4ct.dtsi                | 6 ------
>  14 files changed, 48 deletions(-)
> 
> -- 
> 2.28.0
>