[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20201015120851.229242-1-vitor@massaru.org>
Date: Thu, 15 Oct 2020 09:08:51 -0300
From: Vitor Massaru Iha <vitor@...saru.org>
To: sfr@...b.auug.org.au, skhan@...uxfoundation.org,
brendanhiggins@...gle.com, kunit-dev@...glegroups.com,
johannes@...solutions.net
Cc: linux-kernel@...r.kernel.org, linux-next@...r.kernel.org,
linux-kselftest@...r.kernel.org
Subject: [PATCH] lib: kunit: Fix compilation test when using TEST_BIT_FIELD_COMPILE
A build condition was missing around a compilation test, this compilation
test comes from the original test_bitfield code.
And removed unnecessary code for this test.
Fixes: d2585f5164c2 ("lib: kunit: add bitfield test conversion to KUnit")
Signed-off-by: Vitor Massaru Iha <vitor@...saru.org>
Link: https://lore.kernel.org/linux-next/20201015163056.56fcc835@canb.auug.org.au/
---
lib/bitfield_kunit.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/lib/bitfield_kunit.c b/lib/bitfield_kunit.c
index d63a2be5aff8..1473d8b4bf0f 100644
--- a/lib/bitfield_kunit.c
+++ b/lib/bitfield_kunit.c
@@ -125,7 +125,7 @@ static void __init test_bitfields_variables(struct kunit *context)
CHECK(u64, 0x0000001f8000000ull);
}
-
+#ifdef TEST_BITFIELD_COMPILE
static void __init test_bitfields_compile(struct kunit *context)
{
/* these should fail compilation */
@@ -135,13 +135,11 @@ static void __init test_bitfields_compile(struct kunit *context)
/* this should at least give a warning */
u16_encode_bits(0, 0x60000);
}
+#endif
static struct kunit_case __refdata bitfields_test_cases[] = {
KUNIT_CASE(test_bitfields_constants),
KUNIT_CASE(test_bitfields_variables),
-#ifdef TEST_BITFIELD_COMPILE
- KUNIT_CASE(test_bitfields_compile),
-#endif
{}
};
base-commit: d2585f5164c298aaaed14c2c8d313cbe7bd5b253
--
2.26.2
Powered by blists - more mailing lists