linux-kernel - Re: [PATCH v2] lib: kunit: add list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADQ6JjVxRGLr3-fY-Ovmq+oZHdsNbWg43RVa8-tsT-=3tKb1pA@mail.gmail.com>
Date:   Thu, 15 Oct 2020 14:54:24 -0300
From:   Vitor Massaru Iha <vitor@...saru.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     KUnit Development <kunit-dev@...glegroups.com>,
        Brendan Higgins <brendanhiggins@...gle.com>,
        Marco Elver <elver@...gle.com>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Shuah Khan <skhan@...uxfoundation.org>,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        tglx@...utronix.de, geert@...ux-m68k.org,
        paul.gortmaker@...driver.com, akpm@...ux-foundation.org,
        torvalds@...ux-foundation.org, arnd@...db.de,
        elfring@...rs.sourceforge.net, mhocko@...e.com
Subject: Re: [PATCH v2] lib: kunit: add list_sort test conversion to KUnit

On Thu, Oct 15, 2020 at 7:50 AM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
>
> On Wed, Oct 14, 2020 at 10:46:16PM -0300, Vitor Massaru Iha wrote:
> > This adds the conversion of the runtime tests of test_list_sort,
> > from `lib/test_list_sort.c` to KUnit tests.
>
> Please, provide better commit message. For example, add the output of _succeeded_
> *and* _failed_ test cases (yes, you have to break code manually to reproduce failed
> test cases) _before_ *and* _after_ the change.

Sure, I'll do it. Thanks!

> W/o above information I'm going to NAK this as I promised before.
>
> --
> With Best Regards,
> Andy Shevchenko
>
>