linux-kernel - Re: [PATCH v4 4/9] libperf: Add libperf_evsel_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_Jsq+5_uzAdn+rq-rWVACeaMMd4q+ntxxOd5JisOiBzwvDbw@mail.gmail.com>
Date:   Fri, 16 Oct 2020 16:39:15 -0500
From:   Rob Herring <robh@...nel.org>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Will Deacon <will@...nel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Raphael Gault <raphael.gault@....com>,
        Mark Rutland <mark.rutland@....com>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Ian Rogers <irogers@...gle.com>,
        Honnappa Nagarahalli <honnappa.nagarahalli@....com>,
        Itaru Kitayama <itaru.kitayama@...il.com>
Subject: Re: [PATCH v4 4/9] libperf: Add libperf_evsel__mmap()

On Wed, Oct 14, 2020 at 6:05 AM Jiri Olsa <jolsa@...hat.com> wrote:
>
> On Thu, Oct 01, 2020 at 09:01:11AM -0500, Rob Herring wrote:
>
> SNIP
>
> >
> > +void *perf_evsel__mmap(struct perf_evsel *evsel, int pages)
> > +{
> > +     int ret;
> > +     struct perf_mmap *map;
> > +     struct perf_mmap_param mp = {
> > +             .prot = PROT_READ | PROT_WRITE,
> > +     };
> > +
> > +     if (FD(evsel, 0, 0) < 0)
> > +             return NULL;
> > +
> > +     mp.mask = (pages * page_size) - 1;
> > +
> > +     map = zalloc(sizeof(*map));
> > +     if (!map)
> > +             return NULL;
> > +
> > +     perf_mmap__init(map, NULL, false, NULL);
> > +
> > +     ret = perf_mmap__mmap(map, &mp, FD(evsel, 0, 0), 0);
>
> hum, so you map event for FD(0,0) but later in perf_evsel__read
> you allow to read any cpu/thread combination ending up reading
> data from FD(0,0) map:
>
>         int perf_evsel__read(struct perf_evsel *evsel, int cpu, int thread,
>                              struct perf_counts_values *count)
>         {
>                 size_t size = perf_evsel__read_size(evsel);
>
>                 memset(count, 0, sizeof(*count));
>
>                 if (FD(evsel, cpu, thread) < 0)
>                         return -EINVAL;
>
>                 if (evsel->mmap && !perf_mmap__read_self(evsel->mmap, count))
>                         return 0;
>
>
> I think we should either check cpu == 0, thread == 0, or make it
> general and store perf_evsel::mmap in xyarray as we do for fds

The mmapped read will actually fail and then we fallback here. My main
concern though is adding more overhead on a feature that's meant to be
low overhead (granted, it's not much). Maybe we could add checks on
the mmap that we've opened the event with pid == 0 and cpu == -1 (so
only 1 FD)?

Rob