linux-kernel - Re: [PATCH] Staging: android: ashmem: changed struct file_operations to const file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20201016061813.GA569795@kroah.com>
Date:   Fri, 16 Oct 2020 08:18:13 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Kiran Suren <kirank.suren@...il.com>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: android: ashmem: changed struct file_operations
 to const file_operations

A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Fri, Oct 16, 2020 at 01:38:47AM -0400, Kiran Suren wrote:
> Hi,
> 
> My apologies about the last couple emails, I test built completely the
> wrong file. This is my first attempt at doing patch so I’m still trying to
> get a hang of how all this works. Also, I’m not sure what you mean by the
> signed off line? I believe I did put my actual full name? Again, apologies
> for any inconveniences just trying to get a hang of how the entire process
> works.

For the signed-off-by line, look at your email below:

> 
> On Fri, Oct 16, 2020 at 1:12 AM kiransuren <kirank.suren@...il.com> wrote:
> 
> > From: kiransuren <kirank.suren@...il.com>

That has one name and then:

> >
> > Fixed a coding style issue.
> >
> > Signed-off-by: Kiran Surendran <kirank.suren@...il.com>

This has another.

They have to match, otherwise it doesn't make any sense, right?

thanks,

greg k-h