linux-kernel - Re: [PATCH 3/6] dt-bindings: can: flexcan: add fsl, can-index property to indicate a resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <604a66f6-83ea-630e-f479-fe62189de42a@pengutronix.de>
Date:   Fri, 16 Oct 2020 08:20:18 +0200
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Joakim Zhang <qiangqing.zhang@....com>, robh+dt@...nel.org,
        shawnguo@...nel.org, s.hauer@...gutronix.de
Cc:     devicetree@...r.kernel.org, peng.fan@....com, victor.liu@....com,
        netdev@...r.kernel.org, pankaj.bansal@....com,
        linux-kernel@...r.kernel.org, linux-can@...r.kernel.org,
        linux-imx@....com, kernel@...gutronix.de
Subject: Re: [PATCH 3/6] dt-bindings: can: flexcan: add fsl, can-index
 property to indicate a resource

On 10/16/20 3:43 PM, Joakim Zhang wrote:
> For SoCs with SCU support, need setup stop mode via SCU firmware,
> so this property can help indicate a resource.
> 
> Signed-off-by: Joakim Zhang <qiangqing.zhang@....com>
> ---
>  Documentation/devicetree/bindings/net/can/fsl-flexcan.txt | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> index 6af67f5e581c..839c0c0064a2 100644
> --- a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> +++ b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
> @@ -43,6 +43,10 @@ Optional properties:
>  		  0: clock source 0 (oscillator clock)
>  		  1: clock source 1 (peripheral clock)
>  
> +- fsl,can-index: The index of CAN instance.
> +                 For SoCs with SCU support, need setup stop mode via SCU firmware,
> +                 so this property can help indicate a resource.

This property is not CAN specific. So the name could be more general.

> +
>  - wakeup-source: enable CAN remote wakeup
>  
>  Example:
> @@ -54,4 +58,5 @@ Example:
>  		interrupt-parent = <&mpic>;
>  		clock-frequency = <200000000>; // filled in by bootloader
>  		fsl,clk-source = /bits/ 8 <0>; // select clock source 0 for PE
> +		fsl,can-index = /bits/ 8 <1>; // the second CAN instance
>  	};
> 

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)