linux-kernel - Re: 5.10-rc0: build error in ipi.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 16 Oct 2020 09:28:07 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     Pavel Machek <pavel@....cz>,
        kernel list <linux-kernel@...r.kernel.org>
Subject: Re: 5.10-rc0: build error in ipi.c

On 2020-10-16 00:24, Thomas Gleixner wrote:
> On Thu, Oct 15 2020 at 20:41, Marc Zyngier wrote:
>> On 2020-10-15 18:18, Pavel Machek wrote:
>> diff --git a/kernel/irq/Kconfig b/kernel/irq/Kconfig
>> index 10a5aff4eecc..db923e0da162 100644
>> --- a/kernel/irq/Kconfig
>> +++ b/kernel/irq/Kconfig
>> @@ -81,6 +81,7 @@ config IRQ_FASTEOI_HIERARCHY_HANDLERS
>> 
>>   # Generic IRQ IPI support
>>   config GENERIC_IRQ_IPI
>> +	select IRQ_DOMAIN_HIERARCHY
>>   	bool
> 
> which makes some of the MIPS GENERIC_IRQ_IPI/IRQ_DOMAIN_HIERARCHY
> Kconfig magic in drivers/irqchip/Kconfig obsolete.

Good point. I'll queue this on top:

diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index cd734df57c42..d2a651372e15 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -180,7 +180,6 @@ config IRQ_MIPS_CPU
  	select GENERIC_IRQ_CHIP
  	select GENERIC_IRQ_IPI if SYS_SUPPORTS_MULTITHREADING
  	select IRQ_DOMAIN
-	select IRQ_DOMAIN_HIERARCHY if GENERIC_IRQ_IPI
  	select GENERIC_IRQ_EFFECTIVE_AFF_MASK

  config CLPS711X_IRQCHIP

Thanks,

         M.
-- 
Jazz is not dead. It just smells funny...