linux-kernel - RE: [PATCH] hwmon: add support for SMSC EMC2305/03/02/01 fan controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <VI1PR0401MB244636CEDEEC9E1F84FD18F78F030@VI1PR0401MB2446.eurprd04.prod.outlook.com>
Date:   Fri, 16 Oct 2020 09:24:09 +0000
From:   "Biwen Li (OSS)" <biwen.li@....nxp.com>
To:     Rob Herring <robh@...nel.org>,
        "Biwen Li (OSS)" <biwen.li@....nxp.com>
CC:     "jdelvare@...e.com" <jdelvare@...e.com>,
        "linux@...ck-us.net" <linux@...ck-us.net>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Reinhard Pfau <pfau@...ys.de>
Subject: RE: [PATCH] hwmon: add support for SMSC EMC2305/03/02/01 fan
 controller

> 
> On Mon, Sep 28, 2020 at 06:43:26PM +0800, Biwen Li wrote:
> > From: Reinhard Pfau <pfau@...ys.de>
> >
> > Add support for SMSC EMC2305, EMC2303, EMC2302, EMC2301 fan controller
> > chips.
> > The driver primary supports the EMC2305 chip which provides RPM-based
> > PWM control and monitoring for up to 5 fans.
> >
> > According to the SMSC data sheets the EMC2303, EMC2302 and EMC2301
> > chips have basically the same functionality and register layout, but
> > support less fans and (in case of EMC2302 and EMC2301) less possible I2C
> addresses.
> > The driver supports them, too.
> >
> > The driver supports configuration via devicetree. This can also be
> > used to restrict the fans exposed via sysfs (see doc for details).
> >
> > Signed-off-by: Reinhard Pfau <pfau@...ys.de>
> > Signed-off-by: Biwen Li <biwen.li@....com>
> > ---
> >  .../devicetree/bindings/hwmon/emc2305.txt     |  33 +
> 
> Split to a separate patch and should be in DT schema format.
> checkpatch.pl will tell you both of these things.
Okay, got it, thanks.
> 
> >  Documentation/hwmon/emc2305.rst               |  34 +
> >  MAINTAINERS                                   |   8 +
> >  drivers/hwmon/Kconfig                         |  10 +
> >  drivers/hwmon/Makefile                        |   1 +
> >  drivers/hwmon/emc2305.c                       | 689
> ++++++++++++++++++
> >  6 files changed, 775 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/hwmon/emc2305.txt
> >  create mode 100644 Documentation/hwmon/emc2305.rst  create mode
> > 100644 drivers/hwmon/emc2305.c