lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 16 Oct 2020 12:56:25 +0200 From: Thomas Zimmermann <tzimmermann@...e.de> To: Xu Wang <vulab@...as.ac.cn> Cc: linux-fbdev@...r.kernel.org, arnd@...db.de, b.zolnierkie@...sung.com, jani.nikula@...el.com, daniel.vetter@...ll.ch, gustavoars@...nel.org, dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] video: fbdev: sh_mobile_lcdcfb: Remove redundant null check before clk_prepare_enable/clk_disable_unprepare On Thu, 15 Oct 2020 10:10:15 +0200 Thomas Zimmermann <tzimmermann@...e.de> wrote: > On Wed, 14 Oct 2020 08:57:22 +0000 Xu Wang <vulab@...as.ac.cn> wrote: > > > Because clk_prepare_enable() and clk_disable_unprepare() already checked > > NULL clock parameter, so the additional checks are unnecessary, just > > remove them. > > > > Signed-off-by: Xu Wang <vulab@...as.ac.cn> > > Reviewed-by: Thomas Zimmermann <tzimmermann@...e.de> > Merged into drm-misc-next. Thanks! > > --- > > drivers/video/fbdev/sh_mobile_lcdcfb.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c > > b/drivers/video/fbdev/sh_mobile_lcdcfb.c index c1043420dbd3..c0952cc96bdb > > 100644 --- a/drivers/video/fbdev/sh_mobile_lcdcfb.c > > +++ b/drivers/video/fbdev/sh_mobile_lcdcfb.c > > @@ -341,8 +341,7 @@ static void lcdc_wait_bit(struct sh_mobile_lcdc_priv > > *priv, static void sh_mobile_lcdc_clk_on(struct sh_mobile_lcdc_priv *priv) > > { > > if (atomic_inc_and_test(&priv->hw_usecnt)) { > > - if (priv->dot_clk) > > - clk_prepare_enable(priv->dot_clk); > > + clk_prepare_enable(priv->dot_clk); > > pm_runtime_get_sync(priv->dev); > > } > > } > > @@ -351,8 +350,7 @@ static void sh_mobile_lcdc_clk_off(struct > > sh_mobile_lcdc_priv *priv) { > > if (atomic_sub_return(1, &priv->hw_usecnt) == -1) { > > pm_runtime_put(priv->dev); > > - if (priv->dot_clk) > > - clk_disable_unprepare(priv->dot_clk); > > + clk_disable_unprepare(priv->dot_clk); > > } > > } > > > > > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer
Powered by blists - more mailing lists