linux-kernel - Re: [PATCH] mm: fix potential pte_unmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f99d9457ae88f3692e57cce86d0e22e8@suse.de>
Date:   Fri, 16 Oct 2020 14:37:08 +0200
From:   osalvador@...e.de
To:     Michal Hocko <mhocko@...e.com>
Cc:     Shijie Luo <luoshijie1@...wei.com>, akpm@...ux-foundation.org,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        linmiaohe@...wei.com, linfeilong@...wei.com
Subject: Re: [PATCH] mm: fix potential pte_unmap_unlock pte error

On 2020-10-16 14:31, Michal Hocko wrote:
> I do not like the fix though. The code is really confusing. Why should
> we check for flags in each iteration of the loop when it cannot change?
> Also why should we take the ptl lock in the first place when the look 
> is
> broken out immediately?

About checking the flags:

https://lore.kernel.org/linux-mm/20190320081643.3c4m5tec5vx653sn@d104.suse.de/#t