linux-kernel - Re: [PATCH v2 0/3] drm/panel: mantix panel reset fixes

Open Source and information security mailing list archives

Message-ID: <20201016142916.GA1184974@ravnborg.org>
Date:   Fri, 16 Oct 2020 16:29:16 +0200
From:   Sam Ravnborg <sam@...nborg.org>
To:     Guido Günther <agx@...xcpu.org>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Rob Herring <robh+dt@...nel.org>,
        dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/3] drm/panel: mantix panel reset fixes

Hi Guido.
On Tue, Oct 13, 2020 at 12:32:45PM +0200, Guido Günther wrote:
> 
> The first patch in this series fixes dereferencing a NULL mode in the error
> path. The second one extends the resets to not only reset RESX but also TP_RSTN
> since otherwise the display will stay completely blank. I didn't spot that
> before initial submission since the reset line was bound to the touch
> controller and although that failed to probe it came far enough to deassert the
> reset line (at an arbitrary point in time during boot) and hence we got a
> picture. Since touch and panel are on the same IC they're not completely
> independent and i might have to turn the whole thing into an MFD at some point
> but this series gets the panel to a reliably working state on boot and on fb
> blank/unblank.
> 
> Since the reset-gpios are active low we can deassert in prepare and assert in
> unprepare simplifying the code making sure lines are kept low when the
> panel is off.
> 
> The binding were not part of a stable kernel so I hope it's okay to not worry
> about backward compatibility.
> 
> Changes from v1:
>  - As per review comments by Fabio Estevam
>    https://lore.kernel.org/dri-devel/CAOMZO5B5ECcConvKej=RcaF8wvOxgq7nUzKJ-ad0aSAOzUqtbQ@mail.gmail.com/
>    - Fix typo in commit messages
>  - As per review comments by Rob Herring
>    https://lore.kernel.org/dri-devel/20200929174624.GA832332@bogus/
>    - Don't use an array of reset lines
> 
> Guido Günther (3):
>   drm/panel: mantix: Don't dereference NULL mode
>   drm/panel: mantix: Fix panel reset
>   dt-binding: display: Require two resets on mantix panel

All applied to drm-misc-next and pushed out.
And then I remembered you had commit right - sigh.

	Sam

> 
>  .../display/panel/mantix,mlaf057we51-x.yaml   |  4 +++
>  .../gpu/drm/panel/panel-mantix-mlaf057we51.c  | 25 +++++++++++++------
>  2 files changed, 21 insertions(+), 8 deletions(-)
> 
> -- 
> 2.28.0
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives