linux-kernel - Re: [PATCH] Staging: android: ashmem: changed struct file_operations to const file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20201016051757.GA463503@kroah.com>
Date:   Fri, 16 Oct 2020 07:17:57 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     kiransuren@...osl.org, kirank.suren@...il.com
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: android: ashmem: changed struct file_operations
 to const file_operations

On Fri, Oct 16, 2020 at 01:11:11AM -0400, kiransuren@...osl.org wrote:
> From: kiransuren <kirank.suren@...il.com>

This does not match your signed-off-by line :(

> 
> Fixed a coding style issue.

What issue?  Always be specific.

> 
> Signed-off-by: Kiran Surendran <kirank.suren@...il.com>
> ---
>  drivers/staging/android/ashmem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
> index 10b4be1f3e78..f2b67c4fe8d2 100644
> --- a/drivers/staging/android/ashmem.c
> +++ b/drivers/staging/android/ashmem.c
> @@ -376,7 +376,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr,
>  
>  static int ashmem_mmap(struct file *file, struct vm_area_struct *vma)
>  {
> -	static struct file_operations vmfile_fops;
> +	static const file_operations vmfile_fops;

Why did you not test-build your patch before sending it out?

Don't you think that is a big rude?

Please be more careful.

greg k-h