linux-kernel - Re: [RFC] treewide: cleanup unreachable breaks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 17 Oct 2020 18:24:28 +0200
From:   Martin Blumenstingl <martin.blumenstingl@...glemail.com>
To:     trix@...hat.com
Cc:     linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
        linux-amlogic@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [RFC] treewide: cleanup unreachable breaks

Hi Tom,

(I removed what I believe are irrelevant recipients from this reply)

On Sat, Oct 17, 2020 at 6:10 PM <trix@...hat.com> wrote:
[...]
> diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c
> index e03988698755..66dc452d643a 100644
> --- a/drivers/iio/adc/meson_saradc.c
> +++ b/drivers/iio/adc/meson_saradc.c
> @@ -591,17 +591,15 @@ static int meson_sar_adc_iio_info_read_raw(struct iio_dev *indio_dev,
>
>         switch (mask) {
>         case IIO_CHAN_INFO_RAW:
>                 return meson_sar_adc_get_sample(indio_dev, chan, NO_AVERAGING,
>                                                 ONE_SAMPLE, val);
> -               break;
>
>         case IIO_CHAN_INFO_AVERAGE_RAW:
>                 return meson_sar_adc_get_sample(indio_dev, chan,
>                                                 MEAN_AVERAGING, EIGHT_SAMPLES,
>                                                 val);
> -               break;
>
>         case IIO_CHAN_INFO_SCALE:
>                 if (chan->type == IIO_VOLTAGE) {
>                         ret = regulator_get_voltage(priv->vref);
>                         if (ret < 0) {
for drivers/iio/adc/meson_saradc.c:
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>


Best regards,
Martin