linux-kernel - Re: [PATCH v5] checkpatch: add new exception to repeated word check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABJPP5DuQ_Y0LLS5BzNXUWyxjzp9ts5kgEH-3+7Pn7PPjq0Ljg@mail.gmail.com>
Date:   Sat, 17 Oct 2020 22:19:56 +0530
From:   Dwaipayan Ray <dwaipayanray1@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     linux-kernel-mentees@...ts.linuxfoundation.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Lukas Bulwahn <lukas.bulwahn@...il.com>
Subject: Re: [PATCH v5] checkpatch: add new exception to repeated word check

On Sat, Oct 17, 2020 at 10:03 PM Joe Perches <joe@...ches.com> wrote:
>
> On Sat, 2020-10-17 at 21:57 +0530, Dwaipayan Ray wrote:
> > Recently, commit 4f6ad8aa1eac ("checkpatch: move repeated word test")
> > moved the repeated word test to check for more file types. But after
> > this, if checkpatch.pl is run on MAINTAINERS, it generates several
> > new warnings of the type:
>
> NAK.
>
> Slow down and test before you send more patch versions.
>
> > +                             next if (index(" \t.,;?!", $end_char) == -1);
>
> what does this do?

Um, it checks if end_char is not present in " \t.,;?!".
If end_char doesn't belong to this list, then the check shall
skip. That is the test will skip for "word word:", but will produce
a warning for "word word." or "word word?", etc.

Shouldn't this itself be the case or am I perhaps going wrong
somewhere?

Thanks,
Dwaipayan.