linux-kernel - [PATCH] ipmi_si: replace spin_lock_irqsave by spin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 17 Oct 2020 09:40:10 +0800
From:   Tian Tao <tiantao6@...ilicon.com>
To:     <minyard@....org>, <arnd@...db.de>, <gregkh@...uxfoundation.org>,
        <openipmi-developer@...ts.sourceforge.net>,
        <linux-kernel@...r.kernel.org>
Subject: [PATCH] ipmi_si: replace spin_lock_irqsave by spin_lock in hard IRQ

It is redundant to do irqsave and irqrestore in hardIRQ context.

Signed-off-by: Tian Tao <tiantao6@...ilicon.com>
---
 drivers/char/ipmi/ipmi_si_intf.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
index 45546ac..97452a8 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -1116,7 +1116,6 @@ static void smi_timeout(struct timer_list *t)
 irqreturn_t ipmi_si_irq_handler(int irq, void *data)
 {
 	struct smi_info *smi_info = data;
-	unsigned long   flags;
 
 	if (smi_info->io.si_type == SI_BT)
 		/* We need to clear the IRQ flag for the BT interface. */
@@ -1124,14 +1123,14 @@ irqreturn_t ipmi_si_irq_handler(int irq, void *data)
 				     IPMI_BT_INTMASK_CLEAR_IRQ_BIT
 				     | IPMI_BT_INTMASK_ENABLE_IRQ_BIT);
 
-	spin_lock_irqsave(&(smi_info->si_lock), flags);
+	spin_lock(&(smi_info->si_lock));
 
 	smi_inc_stat(smi_info, interrupts);
 
 	debug_timestamp("Interrupt");
 
 	smi_event_handler(smi_info, 0);
-	spin_unlock_irqrestore(&(smi_info->si_lock), flags);
+	spin_unlock(&(smi_info->si_lock));
 	return IRQ_HANDLED;
 }
 
-- 
2.7.4