lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 16 Oct 2020 18:23:26 -0700 From: Nicolin Chen <nicoleotsuka@...il.com> To: Shengjiu Wang <shengjiu.wang@....com> Cc: timur@...nel.org, Xiubo.Lee@...il.com, festevam@...il.com, broonie@...nel.org, perex@...ex.cz, tiwai@...e.com, alsa-devel@...a-project.org, lgirdwood@...il.com, robh+dt@...nel.org, devicetree@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/2] ASoC: fsl_spdif: Add support for i.MX8QM platform On Thu, Oct 15, 2020 at 01:28:48PM +0800, Shengjiu Wang wrote: > On i.MX8QM, there are separate interrupts for TX and RX. > > As the EDMA can't be configured to swing back to first FIFO > after writing the second FIFO, so we need to force the burst > size to be 2 on i.MX8QM. And EDMA don't support to shift > the data from S24_LE to S16_LE, so the supported TX format > is also different on i.MX8QM. > > Signed-off-by: Shengjiu Wang <shengjiu.wang@....com> One small nit, yet I am okay if you don't resend. So: Acked-by: Nicolin Chen <nicoleotsuka@...il.com> > /* Check if clk is a root clock that does not share clock source with others */ > @@ -1283,6 +1313,8 @@ static int fsl_spdif_probe(struct platform_device *pdev) > /* Initialize this copy of the CPU DAI driver structure */ > memcpy(&spdif_priv->cpu_dai_drv, &fsl_spdif_dai, sizeof(fsl_spdif_dai)); > spdif_priv->cpu_dai_drv.name = dev_name(&pdev->dev); > + spdif_priv->cpu_dai_drv.playback.formats = > + spdif_priv->soc->tx_formats; Kernel no longer has strict 80-character limit now, and it seems to fits 80 characters?
Powered by blists - more mailing lists