linux-kernel - Re: [PATCH v2] iio: adc: mediatek: fix unset field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOwMV_z9B4suGd33H_D6ep-UpXn2W2QyTd8az2C_NERMFALWVA@mail.gmail.com>
Date:   Sun, 18 Oct 2020 21:43:43 +0200
From:   Fabien Parent <fparent@...libre.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        linux-iio <linux-iio@...r.kernel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Jonathan Cameron <jic23@...nel.org>, chun-hung.wu@...iatek.com,
        Alexandru Ardelean <alexandru.ardelean@...log.com>,
        Peter Meerwald <pmeerw@...erw.net>,
        Lars-Peter Clausen <lars@...afoo.de>
Subject: Re: [PATCH v2] iio: adc: mediatek: fix unset field

Hi Andy

On Sun, Oct 18, 2020 at 8:33 PM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
>
> On Sun, Oct 18, 2020 at 9:31 PM Andy Shevchenko
> <andy.shevchenko@...il.com> wrote:
> >
> > On Sun, Oct 18, 2020 at 8:16 PM Fabien Parent <fparent@...libre.com> wrote:
> > >
> > > dev_comp field is used in a couple of places but it is never set. This
> > > results in kernel oops when dereferencing a NULL pointer. Set the
> > > `dev_comp` field correctly in the probe function.
> > >
> > > Fixes: 6d97024dce23 ("iio: adc: mediatek: mt6577-auxadc, add mt6765 support")
> > >
> > > Signed-off-by: Fabien Parent <fparent@...libre.com>
> >
> > Shouldn't be a blank line in the tag block.
> >
> > I think Jonathan can fix it, but be more careful in the future.
>
> One more serious issue, you forgot to add tags you have gotten in the
> previous round.

Thanks for the review. I will make it easy for the maintainer and send
right away a v3 that fixes both issues you pointed out.

> --
> With Best Regards,
> Andy Shevchenko