linux-kernel - Re: [PATCH v3] iio: light: vcnl4035 add i2c_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALudOK5Hy3cU6W+yWAgpqxP-27K2MXiwSwR1x3z=mJjq3y3K8w@mail.gmail.com>
Date:   Mon, 19 Oct 2020 01:31:39 +0530
From:   Vaishnav M A <vaishnav@...gleboard.org>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Jonathan Cameron <jic23@...nel.org>, Wolfram Sang <wsa@...nel.org>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Alexandru Ardelean <alexandru.ardelean@...log.com>,
        Matt Ranostay <matt.ranostay@...sulko.com>,
        linux-iio <linux-iio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Jason Kridner <jkridner@...gleboard.org>,
        Drew Fustini <drew@...gleboard.org>,
        Robert Nelson <robertcnelson@...gleboard.org>,
        Ivan Rajković <rajkovic@...roe.com>
Subject: Re: [PATCH v3] iio: light: vcnl4035 add i2c_device_id

On Sun, Oct 18, 2020 at 11:59 PM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
>
> On Sun, Oct 18, 2020 at 6:47 PM Vaishnav M A <vaishnav@...gleboard.org> wrote:
> >
> > Add i2c_device_id table for the vl53l0x-i2c driver,
> > helps in device instantiation using i2c_new_client_device
>
> In all your patches please refer to the functions like function().
> For example, here is i2c_new_client_device().
>
> > or from userspace in cases where device-tree based description
> > is not possible now (Example: device on a gbphy i2c adapter
> > created by greybus)
>
> Don't forget proper English punctuation, like periods at the end of sentences.
>
> --
> With Best Regards,
> Andy Shevchenko

Thank you Andy for your review, I have updated v4 patch with your suggestions,
https://lore.kernel.org/patchwork/patch/1322219/ (sorry about the
incorrect driver
name in the first-line of the commit message in the v3 version). This is
also fixed in the v4 submission.

Thanks,
Vaishnav