linux-kernel - Re: [PATCH AUTOSEL 5.9 054/111] USB: cdc-acm: handle broken union descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201019071034.GP26280@localhost>
Date:   Mon, 19 Oct 2020 09:10:34 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Sasha Levin <sashal@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Johan Hovold <johan@...nel.org>,
        Daniel Caujolle-Bert <f1rmb.daniel@...il.com>,
        Oliver Neukum <oneukum@...e.com>, linux-usb@...r.kernel.org,
        Konstantin Ryabitsev <konstantin@...uxfoundation.org>
Subject: Re: [PATCH AUTOSEL 5.9 054/111] USB: cdc-acm: handle broken union
 descriptors

On Mon, Oct 19, 2020 at 09:02:18AM +0200, Johan Hovold wrote:
> On Sun, Oct 18, 2020 at 03:17:10PM -0400, Sasha Levin wrote:
> > From: Johan Hovold <johan@...nel.org>
> > 
> > [ Upstream commit 960c7339de27c6d6fec13b54880501c3576bb08d ]
> > 
> > Handle broken union functional descriptors where the master-interface
> > doesn't exist or where its class is of neither Communication or Data
> > type (as required by the specification) by falling back to
> > "combined-interface" probing.
> > 
> > Note that this still allows for handling union descriptors with switched
> > interfaces.
> > 
> > This specifically makes the Whistler radio scanners TRX series devices
> > work with the driver without adding further quirks to the device-id
> > table.
> > 
> > Reported-by: Daniel Caujolle-Bert <f1rmb.daniel@...il.com>
> > Tested-by: Daniel Caujolle-Bert <f1rmb.daniel@...il.com>
> > Acked-by: Oliver Neukum <oneukum@...e.com>
> > Signed-off-by: Johan Hovold <johan@...nel.org>
> > Link: https://lore.kernel.org/r/20200921135951.24045-3-johan@kernel.org
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > Signed-off-by: Sasha Levin <sashal@...nel.org>
> 
> I was surprised to see this picked up by AUTOSEL since I remember adding
> a stable tag to this patch (to v2, changed my mind since v1) -- and it's
> there in the lore link above.
> 
> Greg, just to make sure this wasn't due to a b4 bug; did you drop the
> stable tag on purpose when applying?
> 
> The tag-order has been reshuffled by b4 too it seems (I know, some
> people think that's ok) so maybe it fell out in the process.

Hmm. Apparently the Link-tag that I had added to keep a record of the
descriptors provided in the original report also fell out. Another b4
bug?

Adding Konstantin just in case.

Johan