linux-kernel - Re: [PATCH] arch: um: convert tasklets to use new tasklet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3359192b-8f02-feb4-a9a7-a13b5d876998@cambridgegreys.com>
Date:   Mon, 19 Oct 2020 08:39:05 +0100
From:   Anton Ivanov <anton.ivanov@...bridgegreys.com>
To:     Allen Pais <allen.cryptic@...il.com>, jdike@...toit.com,
        richard@....at, 3chas3@...il.com, axboe@...nel.dk,
        stefanr@...6.in-berlin.de, airlied@...ux.ie, daniel@...ll.ch,
        sre@...nel.org, James.Bottomley@...senPartnership.com,
        kys@...rosoft.com, deller@....de, dmitry.torokhov@...il.com,
        jassisinghbrar@...il.com, shawnguo@...nel.org,
        s.hauer@...gutronix.de, maximlevitsky@...il.com, oakad@...oo.com,
        ulf.hansson@...aro.org, mporter@...nel.crashing.org,
        alex.bou9@...il.com, broonie@...nel.org, martyn@...chs.me.uk,
        manohar.vanga@...il.com, mitch@...oth.com, davem@...emloft.net,
        kuba@...nel.org
Cc:     devel@...verdev.osuosl.org, linux-s390@...r.kernel.org,
        linux-hyperv@...r.kernel.org,
        Romain Perier <romain.perier@...il.com>, keescook@...omium.org,
        linux-parisc@...r.kernel.org, linux-ntb@...glegroups.com,
        netdev@...r.kernel.org, intel-gfx@...ts.freedesktop.org,
        linux-atm-general@...ts.sourceforge.net,
        linux-um@...ts.infradead.org, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, linux-spi@...r.kernel.org,
        linux-block@...r.kernel.org, Allen Pais <allen.lkml@...il.com>,
        linux-input@...r.kernel.org, linux-mmc@...r.kernel.org,
        openipmi-developer@...ts.sourceforge.net,
        linux1394-devel@...ts.sourceforge.net,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] arch: um: convert tasklets to use new tasklet_setup() API



On 17/08/2020 10:15, Allen Pais wrote:
> From: Allen Pais <allen.lkml@...il.com>
> 
> In preparation for unconditionally passing the
> struct tasklet_struct pointer to all tasklet
> callbacks, switch to using the new tasklet_setup()
> and from_tasklet() to pass the tasklet pointer explicitly.
> 
> Signed-off-by: Romain Perier <romain.perier@...il.com>
> Signed-off-by: Allen Pais <allen.lkml@...il.com>
> ---
>   arch/um/drivers/vector_kern.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c
> index 8735c468230a..06980870ae23 100644
> --- a/arch/um/drivers/vector_kern.c
> +++ b/arch/um/drivers/vector_kern.c
> @@ -1196,9 +1196,9 @@ static int vector_net_close(struct net_device *dev)
>   
>   /* TX tasklet */
>   
> -static void vector_tx_poll(unsigned long data)
> +static void vector_tx_poll(struct tasklet_struct *t)
>   {
> -	struct vector_private *vp = (struct vector_private *)data;
> +	struct vector_private *vp = from_tasklet(vp, t, tx_poll);
>   
>   	vp->estats.tx_kicks++;
>   	vector_send(vp->tx_queue);
> @@ -1629,7 +1629,7 @@ static void vector_eth_configure(
>   	});
>   
>   	dev->features = dev->hw_features = (NETIF_F_SG | NETIF_F_FRAGLIST);
> -	tasklet_init(&vp->tx_poll, vector_tx_poll, (unsigned long)vp);
> +	tasklet_setup(&vp->tx_poll, vector_tx_poll);
>   	INIT_WORK(&vp->reset_tx, vector_reset_tx);
>   
>   	timer_setup(&vp->tl, vector_timer_expire, 0);
> 

Acked-By: Anton Ivanov <anton.ivanov@...bridgegreys.com>

-- 
Anton R. Ivanov
Cambridgegreys Limited. Registered in England. Company Number 10273661
https://www.cambridgegreys.com/