linux-kernel - Re: [PATCH] dt-bindings: mailbox: mtk-gce: fix incorrect mbox-cells value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <19590d90-978d-0b03-af79-fd8d7a7f1408@gmail.com>
Date:   Mon, 19 Oct 2020 12:18:35 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Fabien Parent <fparent@...libre.com>, linux-kernel@...r.kernel.org,
        linux-mediatek@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org
Cc:     dennis-yc.hsieh@...iatek.com, ck.hu@...iatek.com,
        bibby.hsieh@...iatek.com, jaswinder.singh@...aro.org
Subject: Re: [PATCH] dt-bindings: mailbox: mtk-gce: fix incorrect mbox-cells
 value



On 18/10/2020 21:30, Fabien Parent wrote:
> As the binding documentation says, #mbox-cells must have a value of 2,
> but the example use a value 3. The MT8173 device tree correctly use
> mbox-cells = <2>. This commit fixes the example.
> 
> Signed-off-by: Fabien Parent <fparent@...libre.com>
> ---

Fixes: 19d8e335d58a ("dt-binding: gce: remove atomic_exec in mboxes property")

With that:
Reviewed-by: Matthias Brugger <matthias.bgg@...il.com>

>   Documentation/devicetree/bindings/mailbox/mtk-gce.txt | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> index cf48cd806e00..7771ecaac586 100644
> --- a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> +++ b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> @@ -47,7 +47,7 @@ Example:
>   		interrupts = <GIC_SPI 135 IRQ_TYPE_LEVEL_LOW>;
>   		clocks = <&infracfg CLK_INFRA_GCE>;
>   		clock-names = "gce";
> -		#mbox-cells = <3>;
> +		#mbox-cells = <2>;
>   	};
>   
>   Example for a client device:
>