linux-kernel - Re: [PATCH] arm64: dts: mediatek: mt8183: fix gce incorrect mbox-cells value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 19 Oct 2020 12:20:06 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Fabien Parent <fparent@...libre.com>, linux-kernel@...r.kernel.org,
        linux-mediatek@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org
Cc:     bibby.hsieh@...iatek.com, robh+dt@...nel.org
Subject: Re: [PATCH] arm64: dts: mediatek: mt8183: fix gce incorrect
 mbox-cells value



On 18/10/2020 21:42, Fabien Parent wrote:
> The binding documentation says:
> - #mbox-cells: Should be 2.
> 	<&phandle channel priority>
> 	phandle: Label name of a gce node.
> 	channel: Channel of mailbox. Be equal to the thread id of GCE.
> 	priority: Priority of GCE thread.
> 
> Fix the value of #mbox-cells.
> 
> Fixes: d3c306e31bc7 ("arm64: dts: add gce node for mt8183")
> Signed-off-by: Fabien Parent <fparent@...libre.com>

Applied, to v5.10-tmp/dts64 thanks!

> ---
>   arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index 102105871db2..9a3cf95676e1 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -352,7 +352,7 @@ gce: mailbox@...38000 {
>   			compatible = "mediatek,mt8183-gce";
>   			reg = <0 0x10238000 0 0x4000>;
>   			interrupts = <GIC_SPI 162 IRQ_TYPE_LEVEL_LOW>;
> -			#mbox-cells = <3>;
> +			#mbox-cells = <2>;
>   			clocks = <&infracfg CLK_INFRA_GCE>;
>   			clock-names = "gce";
>   		};
>