linux-kernel - Re: [PATCH v2] arm64: dts: allwinner: beelink-gs1: Update LED power node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201019103457.imvvjktozc2jybze@gilmour.lan>
Date:   Mon, 19 Oct 2020 12:34:57 +0200
From:   Maxime Ripard <maxime@...no.tech>
To:     Clément Péron <peron.clem@...il.com>
Cc:     Rob Herring <robh+dt@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
        devicetree <devicetree@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] arm64: dts: allwinner: beelink-gs1: Update LED power
 node

On Sun, Oct 18, 2020 at 07:25:10PM +0200, Clément Péron wrote:
> HI Maxime,
> 
> On Mon, 12 Oct 2020 at 13:22, Maxime Ripard <maxime@...no.tech> wrote:
> >
> > Hi!
> >
> > On Sun, Oct 11, 2020 at 11:22:37PM +0200, Clément Péron wrote:
> > > Beelink GS1 LED trigger a warning when running dtbs_check.
> > >
> > > Update the node with a valid pattern property.
> > >
> > > Also add the function and the color of the LED and drop the
> > > label which is deprecated.
> > >
> > > Signed-off-by: Clément Péron <peron.clem@...il.com>
> > > ---
> > >  arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts | 6 ++++--
> > >  1 file changed, 4 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> > > index 3f7ceeb1a767..a364cb4e5b3f 100644
> > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> > > @@ -7,6 +7,7 @@
> > >  #include "sun50i-h6-cpu-opp.dtsi"
> > >
> > >  #include <dt-bindings/gpio/gpio.h>
> > > +#include <dt-bindings/leds/common.h>
> > >
> > >  / {
> > >       model = "Beelink GS1";
> > > @@ -43,8 +44,9 @@ ext_osc32k: ext_osc32k_clk {
> > >       leds {
> > >               compatible = "gpio-leds";
> > >
> > > -             power {
> > > -                     label = "beelink:white:power";
> > > +             led-0 {
> > > +                     function = LED_FUNCTION_POWER;
> > > +                     color = <LED_COLOR_ID_WHITE>;
> > >                       gpios = <&r_pio 0 4 GPIO_ACTIVE_HIGH>; /* PL4 */
> > >                       default-state = "on";
> > >               };
> >
> > Doesn't that also change the sysfs file that LED is exposed to the userspace with?
> 
> Indeed the previous led sysfs:
> /sys/class/leds/beelink:white:power/
> is now
> /sys/class/leds/white:power/
> 
> Do you want me to keep the label property to avoid this sysfs change ?

I don't know, the documentation seems to indicate that we should use one
or the other, but I'm not sure if both makes sense or not. I guess we
should ask Pavel or Rob?

Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)