linux-kernel - Re: [PATCH v3] mm/compaction: Rename 'start_pfn' to 'iteration_start_pfn' in compact

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2dfd5820-ca92-8a73-6dcb-00b6ce6c735a@redhat.com>
Date:   Mon, 19 Oct 2020 13:54:44 +0200
From:   David Hildenbrand <david@...hat.com>
To:     yanfei.xu@...driver.com, akpm@...ux-foundation.org, vbabka@...e.cz,
        pankaj.gupta.linux@...il.com
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] mm/compaction: Rename 'start_pfn' to
 'iteration_start_pfn' in compact_zone()

On 19.10.20 13:50, yanfei.xu@...driver.com wrote:
> From: Yanfei Xu <yanfei.xu@...driver.com>
> 
> There are two 'start_pfn' declared in compact_zone() which have
> different meaning. Rename the second one to 'iteration_start_pfn'
> to prevent confusion.
> 
> BTW, remove an useless semicolon.
> 
> Signed-off-by: Yanfei Xu <yanfei.xu@...driver.com>
> Acked-by: David Hildenbrand <david@...hat.com>

^ huh, where does that come from? (you should only add acks in case they
were explicitly spelled out)

Anyhow, now you can keep it :)

Acked-by: David Hildenbrand <david@...hat.com>


-- 
Thanks,

David / dhildenb