linux-kernel - Re: [PATCH v10 09/15] usb: typec: tcpm: frs sourcing vbus callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201019134048.GD1667571@kuha.fi.intel.com>
Date:   Mon, 19 Oct 2020 16:40:48 +0300
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Badhri Jagan Sridharan <badhri@...gle.com>
Cc:     Guenter Roeck <linux@...ck-us.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rob Herring <robh+dt@...nel.org>,
        Lee Jones <lee.jones@...aro.org>,
        Mark Brown <broonie@...nel.org>,
        Maxime Ripard <mripard@...nel.org>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Thierry Reding <treding@...dia.com>,
        Prashant Malani <pmalani@...omium.org>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org, Amelie Delaunay <amelie.delaunay@...com>
Subject: Re: [PATCH v10 09/15] usb: typec: tcpm: frs sourcing vbus callback

On Wed, Oct 07, 2020 at 11:15:50PM -0700, Badhri Jagan Sridharan wrote:
> During FRS hardware autonomously starts to source vbus. Provide
> callback to perform chip specific operations.
> 
> Signed-off-by: Badhri Jagan Sridharan <badhri@...gle.com>

Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

> ---
> Introduced in v9. No chages since then.
> ---
>  drivers/usb/typec/tcpm/tcpm.c | 9 +++++++++
>  include/linux/usb/tcpm.h      | 4 ++++
>  2 files changed, 13 insertions(+)
> 
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index 55535c4f66bf..02b7f623f584 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -4090,7 +4090,16 @@ static void _tcpm_pd_vbus_on(struct tcpm_port *port)
>  	case SRC_TRY_DEBOUNCE:
>  		/* Do nothing, waiting for sink detection */
>  		break;
> +	case FR_SWAP_SEND:
> +	case FR_SWAP_SEND_TIMEOUT:
> +	case FR_SWAP_SNK_SRC_TRANSITION_TO_OFF:
> +	case FR_SWAP_SNK_SRC_SOURCE_VBUS_APPLIED:
> +		if (port->tcpc->frs_sourcing_vbus)
> +			port->tcpc->frs_sourcing_vbus(port->tcpc);
> +		break;
>  	case FR_SWAP_SNK_SRC_NEW_SINK_READY:
> +		if (port->tcpc->frs_sourcing_vbus)
> +			port->tcpc->frs_sourcing_vbus(port->tcpc);
>  		tcpm_set_state(port, FR_SWAP_SNK_SRC_SOURCE_VBUS_APPLIED, 0);
>  		break;
>  
> diff --git a/include/linux/usb/tcpm.h b/include/linux/usb/tcpm.h
> index 09762d26fa0c..7303f518ba49 100644
> --- a/include/linux/usb/tcpm.h
> +++ b/include/linux/usb/tcpm.h
> @@ -83,6 +83,9 @@ enum tcpm_transmit_type {
>   *		Optional; Called to enable/disable PD 3.0 fast role swap.
>   *		Enabling frs is accessory dependent as not all PD3.0
>   *		accessories support fast role swap.
> + * @frs_sourcing_vbus:
> + *		Optional; Called to notify that vbus is now being sourced.
> + *		Low level drivers can perform chip specific operations, if any.
>   */
>  struct tcpc_dev {
>  	struct fwnode_handle *fwnode;
> @@ -109,6 +112,7 @@ struct tcpc_dev {
>  			   const struct pd_message *msg);
>  	int (*set_bist_data)(struct tcpc_dev *dev, bool on);
>  	int (*enable_frs)(struct tcpc_dev *dev, bool enable);
> +	void (*frs_sourcing_vbus)(struct tcpc_dev *dev);
>  };
>  
>  struct tcpm_port;
> -- 
> 2.28.0.806.g8561365e88-goog

thanks,

-- 
heikki