linux-kernel - Re: [PATCH] cachefiles: Drop superfluous readpages aops NULL check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201019150537.GS20115@casper.infradead.org>
Date:   Mon, 19 Oct 2020 16:05:37 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     David Howells <dhowells@...hat.com>
Cc:     torvalds@...ux-foundation.org, Takashi Iwai <tiwai@...e.de>,
        dwysocha@...hat.com, linux-afs@...ts.infradead.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cachefiles: Drop superfluous readpages aops NULL check

On Mon, Oct 19, 2020 at 03:56:54PM +0100, David Howells wrote:
> From: Takashi Iwai <tiwai@...e.de>
> 
> After the recent actions to convert readpages aops to readahead, the
> NULL checks of readpages aops in cachefiles_read_or_alloc_page() may
> hit falsely.  More badly, it's an ASSERT() call, and this panics.
> 
> Drop the superfluous NULL checks for fixing this regression.
> 
> [DH: Note that cachefiles never actually used readpages, so this check was
>  never actually necessary]
> 
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=208883
> BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1175245
> Fixes: 9ae326a69004 ("CacheFiles: A cache that backs onto a mounted filesystem")
> Signed-off-by: Takashi Iwai <tiwai@...e.de>
> Signed-off-by: David Howells <dhowells@...hat.com>
> cc: Matthew Wilcox (Oracle) <willy@...radead.org>

Acked-by: Matthew Wilcox (Oracle) <willy@...radead.org>