linux-kernel - Re: [PATCH v16 1/4] Add flags option to get xattr method paired to __vfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202010192302.bg4ZLD64-lkp@intel.com>
Date:   Mon, 19 Oct 2020 23:15:40 +0800
From:   kernel test robot <lkp@...el.com>
To:     Mark Salyzyn <salyzyn@...roid.com>, linux-kernel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        kernel-team@...roid.com, Mark Salyzyn <salyzyn@...roid.com>,
        Jan Kara <jack@...e.cz>, Jeff Layton <jlayton@...nel.org>,
        David Sterba <dsterba@...e.com>,
        "Darrick J . Wong" <darrick.wong@...cle.com>,
        Mike Marshall <hubcap@...ibond.com>,
        Stephen Smalley <sds@...ho.nsa.gov>,
        John Stultz <john.stultz@...aro.org>
Subject: Re: [PATCH v16 1/4] Add flags option to get xattr method paired to
 __vfs_getxattr

Hi Mark,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on miklos-vfs/overlayfs-next]
[also build test ERROR on ext4/dev linus/master v5.9 next-20201016]
[cannot apply to security/next-testing]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Mark-Salyzyn/overlayfs-override_creds-off-nested-get-xattr-fix/20201019-195516
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git overlayfs-next
config: powerpc64-randconfig-r013-20201019 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 094e9f4779eb9b5c6a49014f2f80b8cbb833572f)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install powerpc64 cross compiling tool for clang build
        # apt-get install binutils-powerpc64-linux-gnu
        # https://github.com/0day-ci/linux/commit/1e4bdc66a19e446b472fa59b08513954e0b4ea7b
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Mark-Salyzyn/overlayfs-override_creds-off-nested-get-xattr-fix/20201019-195516
        git checkout 1e4bdc66a19e446b472fa59b08513954e0b4ea7b
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> fs/ext4/xattr_hurd.c:49:9: error: incompatible function pointer types initializing 'int (*)(const struct xattr_handler *, struct dentry *, struct inode *, const char *, void *, size_t, int)' (aka 'int (*)(const struct xattr_handler *, struct dentry *, struct inode *, const char *, void *, unsigned long, int)') with an expression of type 'int (const struct xattr_handler *, struct dentry *, struct inode *, const char *, void *, size_t)' (aka 'int (const struct xattr_handler *, struct dentry *, struct inode *, const char *, void *, unsigned long)') [-Werror,-Wincompatible-function-pointer-types]
           .get    = ext4_xattr_hurd_get,
                     ^~~~~~~~~~~~~~~~~~~
   1 error generated.

vim +49 fs/ext4/xattr_hurd.c

88ee9d571b6d8ed Jan (janneke  Nieuwenhuizen 2020-05-25  45) 
88ee9d571b6d8ed Jan (janneke  Nieuwenhuizen 2020-05-25  46) const struct xattr_handler ext4_xattr_hurd_handler = {
88ee9d571b6d8ed Jan (janneke  Nieuwenhuizen 2020-05-25  47) 	.prefix	= XATTR_HURD_PREFIX,
88ee9d571b6d8ed Jan (janneke  Nieuwenhuizen 2020-05-25  48) 	.list	= ext4_xattr_hurd_list,
88ee9d571b6d8ed Jan (janneke  Nieuwenhuizen 2020-05-25 @49) 	.get	= ext4_xattr_hurd_get,

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (30246 bytes)