linux-kernel - Re: [PATCH 1/4] KVM: PPC: Book3S HV: Make struct kernel_param

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e1945b90-c97c-f998-56b2-e5635992848a@redhat.com>
Date:   Mon, 19 Oct 2020 18:01:15 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Joe Perches <joe@...ches.com>, Paul Mackerras <paulus@...abs.org>
Cc:     Michael Ellerman <mpe@...erman.id.au>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Sean Christopherson <sean.j.christopherson@...el.com>,
        Ram Pai <linuxram@...ibm.com>,
        Bharata B Rao <bharata@...ux.ibm.com>,
        Laurent Dufour <ldufour@...ux.ibm.com>,
        Nicholas Piggin <npiggin@...il.com>,
        Athira Rajeev <atrajeev@...ux.vnet.ibm.com>,
        Tianjia Zhang <tianjia.zhang@...ux.alibaba.com>,
        Davidlohr Bueso <dave@...olabs.net>, kvm-ppc@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] KVM: PPC: Book3S HV: Make struct kernel_param_ops
 definition const

On 04/10/20 02:18, Joe Perches wrote:
> This should be const, so make it so.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  arch/powerpc/kvm/book3s_hv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c
> index 4ba06a2a306c..2b215852cdc9 100644
> --- a/arch/powerpc/kvm/book3s_hv.c
> +++ b/arch/powerpc/kvm/book3s_hv.c
> @@ -111,7 +111,7 @@ module_param(one_vm_per_core, bool, S_IRUGO | S_IWUSR);
>  MODULE_PARM_DESC(one_vm_per_core, "Only run vCPUs from the same VM on a core (requires indep_threads_mode=N)");
>  
>  #ifdef CONFIG_KVM_XICS
> -static struct kernel_param_ops module_param_ops = {
> +static const struct kernel_param_ops module_param_ops = {
>  	.set = param_set_int,
>  	.get = param_get_int,
>  };
> 

Queued, thanks.

Paolo