linux-kernel - Re: sysfs filenames with spaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201019182721.GA14004@duo.ucw.cz>
Date:   Mon, 19 Oct 2020 20:27:21 +0200
From:   Pavel Machek <pavel@....cz>
To:     Joe Perches <joe@...ches.com>
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: Re: sysfs filenames with spaces

On Tue 2020-10-13 12:48:49, Joe Perches wrote:
> On Tue, 2020-10-13 at 19:17 +0200, Pavel Machek wrote:
> > On Mon 2020-10-05 19:41:15, Joe Perches wrote:
> > > This doesn't seem like a great idea to me.
> > > 
> > > For my system I've got:
> > > 
> > > /sys/devices/platform/Fixed MDIO bus.0/
> > > /sys/bus/platform/drivers/int3401 thermal/
> > > /sys/bus/platform/drivers/int3403 thermal/
> > > /sys/bus/platform/drivers/int3400 thermal/
> > > /sys/bus/mdio_bus/drivers/Generic PHY/
> > > /sys/bus/mdio_bus/drivers/Generic Clause 45 PHY/
> > > /sys/bus/pnp/drivers/i8042 aux/
> > > /sys/bus/pnp/drivers/i8042 kbd/
> > > /sys/bus/i2c/drivers/CHT Whiskey Cove PMIC/
> > > 
> > > Could these filenames be avoided in the future or
> > > even renamed today?
> > 
> > Does not look like great idea to me, either. Hmm. Is there filename
> > with "/" in it? :-)
> > 
> > But I guess you'd need to cc relevant maintainers and that this is
> > going to be a bit of whack-a-mole.
> 
> An option might be to convert any invalid filename
> via an alloc and substitution in sysfs_add_file
> and similar free in sysfs_remove_file.
> 
> Emitting a logging message describing any new name
> would be useful too.

I believe that would be dangerous... renaming existing entries and
risking duplicities.

But ... some kind of warning when such entry is created might be good,
we'd then fix them manually.

Best regards,
								Pavel

-- 
http://www.livejournal.com/~pavelmachek

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)