linux-kernel - Re: [PATCH] pinctrl: remove unneeded break

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 19 Oct 2020 22:22:08 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     trix@...hat.com
Cc:     Kukjin Kim <kgene@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>, tomasz.figa@...il.com,
        s.nawrocki@...sung.com, Linus Walleij <linus.walleij@...aro.org>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        linux-samsung-soc@...r.kernel.org,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: remove unneeded break

On Mon, Oct 19, 2020 at 10:04 PM <trix@...hat.com> wrote:
>
> From: Tom Rix <trix@...hat.com>
>
> A break is not needed if it is preceded by a return

When it's a single driver, use the proper prefix in the Subject line.

Also use proper English punctuation, i.e. period at the end of commit message.

>
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>  drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c
> index 5e24838a582f..2223ead5bd72 100644
> --- a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c
> +++ b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c
> @@ -108,19 +108,14 @@ static int s3c24xx_eint_get_trigger(unsigned int type)
>         switch (type) {
>         case IRQ_TYPE_EDGE_RISING:
>                 return EINT_EDGE_RISING;
> -               break;
>         case IRQ_TYPE_EDGE_FALLING:
>                 return EINT_EDGE_FALLING;
> -               break;
>         case IRQ_TYPE_EDGE_BOTH:
>                 return EINT_EDGE_BOTH;
> -               break;
>         case IRQ_TYPE_LEVEL_HIGH:
>                 return EINT_LEVEL_HIGH;
> -               break;
>         case IRQ_TYPE_LEVEL_LOW:
>                 return EINT_LEVEL_LOW;
> -               break;
>         default:
>                 return -EINVAL;
>         }
> --
> 2.18.1
>


-- 
With Best Regards,
Andy Shevchenko