linux-kernel - Re: [PATCH] mtd: remove unneeded break

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFLxGvwAVbpUe221N-qS19aFSaJ4hM=J=veHfi+4wAkNTNGAog@mail.gmail.com>
Date:   Mon, 19 Oct 2020 22:04:18 +0200
From:   Richard Weinberger <richard.weinberger@...il.com>
To:     trix@...hat.com
Cc:     Miquel Raynal <miquel.raynal@...tlin.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        linux-mtd@...ts.infradead.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mtd: remove unneeded break

On Mon, Oct 19, 2020 at 9:23 PM <trix@...hat.com> wrote:
>
> From: Tom Rix <trix@...hat.com>
>
> A break is not needed if it is preceded by a return
>
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>  drivers/mtd/mtdchar.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mtd/mtdchar.c b/drivers/mtd/mtdchar.c
> index b40f46a43fc6..323035d4f2d0 100644
> --- a/drivers/mtd/mtdchar.c
> +++ b/drivers/mtd/mtdchar.c
> @@ -881,7 +881,6 @@ static int mtdchar_ioctl(struct file *file, u_int cmd, u_long arg)
>                 if (copy_from_user(&offs, argp, sizeof(loff_t)))
>                         return -EFAULT;
>                 return mtd_block_isbad(mtd, offs);
> -               break;
>         }
>
>         case MEMSETBADBLOCK:
> @@ -891,7 +890,6 @@ static int mtdchar_ioctl(struct file *file, u_int cmd, u_long arg)
>                 if (copy_from_user(&offs, argp, sizeof(loff_t)))
>                         return -EFAULT;
>                 return mtd_block_markbad(mtd, offs);
> -               break;

Acked-by: Richard Weinberger <richard@....at>

Do you want to route this patch through mtd or do you carry it?

-- 
Thanks,
//richard