linux-kernel - Re: [PATCH] security: remove unneeded break

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9aeb4532d84e9d52444d67ff2d2e0e6c438e0a7d.camel@linux.ibm.com>
Date:   Tue, 20 Oct 2020 16:45:49 -0400
From:   Mimi Zohar <zohar@...ux.ibm.com>
To:     trix@...hat.com, dmitry.kasatkin@...il.com, jmorris@...ei.org,
        serge@...lyn.com, jejb@...ux.ibm.com,
        jarkko.sakkinen@...ux.intel.com, dhowells@...hat.com,
        mortonm@...omium.org
Cc:     linux-integrity@...r.kernel.org,
        linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org, keyrings@...r.kernel.org
Subject: Re: [PATCH] security: remove unneeded break

On Mon, 2020-10-19 at 10:36 -0700, trix@...hat.com wrote:
> From: Tom Rix <trix@...hat.com>
> 
> A break is not needed if it is preceded by a return
> 
> Signed-off-by: Tom Rix <trix@...hat.com>

Recently "fall through" comments were added before any case statement
without a preceeding break.  Have you made sure these changes won't be
flagged.   Assuming you have,

Acked-by: Mimi Zohar <zohar@...ux.ibm.com>

Mimi