linux-kernel - Re: [PATCH v5 2/2] leds: mt6360: Add LED driver for MT6360

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8925db23-5cc4-3c5f-932a-461fe6450dad@gmail.com>
Date:   Tue, 20 Oct 2020 23:46:57 +0200
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Gene Chen <gene.chen.richtek@...il.com>
Cc:     Pavel Machek <pavel@....cz>, Rob Herring <robh+dt@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Dan Murphy <dmurphy@...com>,
        Linux LED Subsystem <linux-leds@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Gene Chen <gene_chen@...htek.com>, Wilma.Wu@...iatek.com,
        shufan_lee@...htek.com, cy_huang@...htek.com,
        benjamin.chao@...iatek.com
Subject: Re: [PATCH v5 2/2] leds: mt6360: Add LED driver for MT6360

On 10/20/20 8:44 AM, Gene Chen wrote:
> Jacek Anaszewski <jacek.anaszewski@...il.com> 於 2020年10月9日 週五 上午5:51寫道：
>>
>> Hi Gene,
>>
>> On 10/7/20 3:42 AM, Gene Chen wrote:
>>> From: Gene Chen <gene_chen@...htek.com>
>>>
>>> Add MT6360 LED driver include 2-channel Flash LED with torch/strobe mode,
>>> 3-channel RGB LED support Register/Flash/Breath Mode, and 1-channel for
>>> moonlight LED.
>>>
>>> Signed-off-by: Gene Chen <gene_chen@...htek.com>
>>> ---
>>>    drivers/leds/Kconfig       |  12 +
>>>    drivers/leds/Makefile      |   1 +
>>>    drivers/leds/leds-mt6360.c | 783 +++++++++++++++++++++++++++++++++++++++++++++
>>>    3 files changed, 796 insertions(+)
>>>    create mode 100644 drivers/leds/leds-mt6360.c
>>>
>>> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
>>> index 1c181df..c7192dd 100644
>>> --- a/drivers/leds/Kconfig
>>> +++ b/drivers/leds/Kconfig
>>> @@ -271,6 +271,18 @@ config LEDS_MT6323
>>>          This option enables support for on-chip LED drivers found on
>>>          Mediatek MT6323 PMIC.
>>>
>>> +config LEDS_MT6360
>>> +     tristate "LED Support for Mediatek MT6360 PMIC"
>>> +     depends on LEDS_CLASS_FLASH && OF
>>> +     depends on LEDS_CLASS_MULTICOLOR
>>
>> Since CONFIG_LED_CLASS_MULTICOLOR can be turned off you need to have
>> below instead:
>>
>> depends on LEDS_CLASS_MULTICOLOR || !!LEDS_CLASS_MULTICOLOR
>>
>> Unless you want to prevent enabling the driver without RGB LED,
>> but that does not seem to be reasonable at first glance.
>>
> 
> May I change to "select LEDS_CLASS_MULTICOLOR"?
> I suppose RGB always use multicolor mode.

You will also have moonlight LED that will not need multicolor
framework. Is it somehow troublesome to keep "depends on"?

-- 
Best regards,
Jacek Anaszewski