linux-kernel - Re: [Industrypack-devel] [PATCH] ipack: iopctal: remove unneeded break

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <82a6b8eee085b0e6df7c89d64721c3fb6719ba89.camel@igalia.com>
Date:   Tue, 20 Oct 2020 07:50:39 +0200
From:   Samuel Iglesias Gonsálvez 
        <siglesias@...lia.com>
To:     trix@...hat.com, jens.taprogge@...rogge.org,
        gregkh@...uxfoundation.org, arnd@...db.de
Cc:     linux-kernel@...r.kernel.org,
        industrypack-devel@...ts.sourceforge.net
Subject: Re: [Industrypack-devel] [PATCH] ipack: iopctal: remove unneeded
 break

Hi Tom,

Thanks for the patch!

Patch is,

Acked-by: Samuel Iglesias Gonsalvez <siglesias@...lia.com>

Greg, Would you mind picking this patch through your char-misc
tree?

Thanks!

Sam

On Mon, 2020-10-19 at 12:32 -0700, trix@...hat.com wrote:
> From: Tom Rix <trix@...hat.com>
> 
> A break is not needed if it is preceded by a return
> 
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>  drivers/ipack/devices/ipoctal.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/ipack/devices/ipoctal.c
> b/drivers/ipack/devices/ipoctal.c
> index d480a514c983..3940714e4397 100644
> --- a/drivers/ipack/devices/ipoctal.c
> +++ b/drivers/ipack/devices/ipoctal.c
> @@ -544,7 +544,6 @@ static void ipoctal_set_termios(struct tty_struct
> *tty,
>  		break;
>  	default:
>  		return;
> -		break;
>  	}
>  
>  	baud = tty_get_baud_rate(tty);

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)