[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <3e773fac-6403-560a-45d6-af949deef453@linux.alibaba.com>
Date: Tue, 20 Oct 2020 09:20:10 +0800
From: Joseph Qi <joseph.qi@...ux.alibaba.com>
To: trix@...hat.com, mark@...heh.com, jlbec@...lplan.org,
davem@...emloft.net, akpm@...ux-foundation.org,
willy@...radead.org, alex.shi@...ux.alibaba.com
Cc: ocfs2-devel@....oracle.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs: ocfs2 remove unneeded break
On 2020/10/20 01:52, trix@...hat.com wrote:
> From: Tom Rix <trix@...hat.com>
>
> A break is not needed if it is preceded by a goto
>
> Signed-off-by: Tom Rix <trix@...hat.com>
Acked-by: Joseph Qi <joseph.qi@...ux.alibaba.com>
> ---
> fs/ocfs2/cluster/tcp.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ocfs2/cluster/tcp.c b/fs/ocfs2/cluster/tcp.c
> index 79a231719460..3bd8119bed5e 100644
> --- a/fs/ocfs2/cluster/tcp.c
> +++ b/fs/ocfs2/cluster/tcp.c
> @@ -1198,7 +1198,6 @@ static int o2net_process_message(struct o2net_sock_container *sc,
> msglog(hdr, "bad magic\n");
> ret = -EINVAL;
> goto out;
> - break;
> }
>
> /* find a handler for it */
>
Powered by blists - more mailing lists