linux-kernel - RE: [PATCH V3 06/10] can: flexcan: disable wakeup in flexcan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 20 Oct 2020 10:29:35 +0000
From:   Joakim Zhang <qiangqing.zhang@....com>
To:     Marc Kleine-Budde <mkl@...gutronix.de>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>
CC:     "kernel@...gutronix.de" <kernel@...gutronix.de>,
        dl-linux-imx <linux-imx@....com>, Ying Liu <victor.liu@....com>,
        "linux-can@...r.kernel.org" <linux-can@...r.kernel.org>,
        Pankaj Bansal <pankaj.bansal@....com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH V3 06/10] can: flexcan: disable wakeup in flexcan_remove()


Hi Marc,

> -----Original Message-----
> From: Marc Kleine-Budde <mkl@...gutronix.de>
> Sent: 2020年10月20日 17:31
> To: Joakim Zhang <qiangqing.zhang@....com>; robh+dt@...nel.org;
> shawnguo@...nel.org; s.hauer@...gutronix.de
> Cc: kernel@...gutronix.de; dl-linux-imx <linux-imx@....com>; Ying Liu
> <victor.liu@....com>; linux-can@...r.kernel.org; Pankaj Bansal
> <pankaj.bansal@....com>; netdev@...r.kernel.org;
> linux-kernel@...r.kernel.org
> Subject: Re: [PATCH V3 06/10] can: flexcan: disable wakeup in flexcan_remove()
> 
> On 10/20/20 5:53 PM, Joakim Zhang wrote:
> > Disable wakeup in flexcan_remove().
> 
> The patch looks good, please explain why this is needed.

Okay, Can I resend this patch individually?

Joakim
> Marc
> 
> >
> > Fixes: de3578c198c6 ("can: flexcan: add self wakeup support")
> > Fixes: 915f9666421c ("can: flexcan: add support for DT property
> > 'wakeup-source'")
> > Signed-off-by: Joakim Zhang <qiangqing.zhang@....com>
> > ---
> >  drivers/net/can/flexcan.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
> > index 06f94b6f0ebe..881799bd9c5e 100644
> > --- a/drivers/net/can/flexcan.c
> > +++ b/drivers/net/can/flexcan.c
> > @@ -2062,6 +2062,8 @@ static int flexcan_remove(struct platform_device
> > *pdev)  {
> >  	struct net_device *dev = platform_get_drvdata(pdev);
> >
> > +	device_set_wakeup_enable(&pdev->dev, false);
> > +	device_set_wakeup_capable(&pdev->dev, false);
> >  	unregister_flexcandev(dev);
> >  	pm_runtime_disable(&pdev->dev);
> >  	free_candev(dev);
> >
> 
> 
> --
> Pengutronix e.K.                 | Marc Kleine-Budde           |
> Embedded Linux                   | https://www.pengutronix.de  |
> Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
> Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |