linux-kernel - Re: [PATCH RFC 7/8] arm64: kasan: Add system_supports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAAeHK+wQWv7w9w2TgdvNFp_5KdjMF3+R1vLNDTJiWMZQ+hBbzw@mail.gmail.com>
Date:   Tue, 20 Oct 2020 14:39:24 +0200
From:   Andrey Konovalov <andreyknvl@...gle.com>
To:     Hillf Danton <hdanton@...a.com>
Cc:     Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        Vincenzo Frascino <vincenzo.frascino@....com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Alexander Potapenko <glider@...gle.com>,
        Marco Elver <elver@...gle.com>,
        Evgenii Stepanov <eugenis@...gle.com>,
        Andrey Ryabinin <aryabinin@...tuozzo.com>,
        Elena Petrova <lenaptr@...gle.com>,
        Branislav Rankov <Branislav.Rankov@....com>,
        Kevin Brodsky <kevin.brodsky@....com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        kasan-dev <kasan-dev@...glegroups.com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RFC 7/8] arm64: kasan: Add system_supports_tags helper

On Tue, Oct 20, 2020 at 8:23 AM Hillf Danton <hdanton@...a.com> wrote:
>
> On Wed, 14 Oct 2020 22:44:35 +0200
> >
> >  #ifdef CONFIG_KASAN_HW_TAGS
> > +#define arch_system_supports_tags()          system_supports_mte()
>
> s/system_supports/support/ in order to look more like the brother of
>
> >  #define arch_init_tags(max_tag)                      mte_init_tags(max_tag)

Well, init_tags() does initialize tags, but supports_tags() doesn't
not enable support for tags, and rather returns its status. So using
"support" here would be wrong from the English language standpoint.