linux-kernel - Re: [PATCH 05/29] arm64: dts: amlogic: meson-g12: Set FL-adj property value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cfae6b6a-ceda-f9ca-677d-46d2c25d584a@baylibre.com>
Date:   Tue, 20 Oct 2020 15:06:25 +0200
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Serge Semin <Sergey.Semin@...kalelectronics.ru>,
        Felipe Balbi <balbi@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Kevin Hilman <khilman@...libre.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Cc:     Serge Semin <fancer.lancer@...il.com>,
        linux-arm-kernel@...ts.infradead.org, linux-usb@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-amlogic@...ts.infradead.org
Subject: Re: [PATCH 05/29] arm64: dts: amlogic: meson-g12: Set FL-adj property
 value

Hi Serge,

On 20/10/2020 13:59, Serge Semin wrote:
> In accordance with the DWC USB3 bindings the property is supposed to have
> uint32 type. It's erroneous from the DT schema and driver points of view
> to declare it as boolean. As Neil suggested set it to 0x20 so not break
> the platform and to make the dtbs checker happy.
> 
> Link: https://lore.kernel.org/linux-usb/20201010224121.12672-16-Sergey.Semin@baikalelectronics.ru/
> Signed-off-by: Serge Semin <Sergey.Semin@...kalelectronics.ru>
> ---
>  arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> index 1e83ec5b8c91..3033ab2be1ff 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> @@ -2380,7 +2380,7 @@ dwc3: usb@...00000 {
>  				interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
>  				dr_mode = "host";
>  				snps,dis_u2_susphy_quirk;
> -				snps,quirk-frame-length-adjustment;
> +				snps,quirk-frame-length-adjustment = <0x20>;
>  				snps,parkmode-disable-ss-quirk;
>  			};
>  		};
> 

You were faster than me !

Reviewed-by: Neil Armstrong <narmstrong@...libre.com>