linux-kernel - Re: [PATCH v6 2/6] drivers: mfd: Add a driver for iEi WT61P803 PUZZLE MCU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 20 Oct 2020 10:19:44 +0800
From:   kernel test robot <lkp@...el.com>
To:     Luka Kovacic <luka.kovacic@...tura.hr>,
        linux-kernel@...r.kernel.org, linux-hwmon@...r.kernel.org,
        linux-leds@...r.kernel.org, devicetree@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, lee.jones@...aro.org, pavel@....cz,
        dmurphy@...com, robh+dt@...nel.org, jdelvare@...e.com,
        linux@...ck-us.net
Subject: Re: [PATCH v6 2/6] drivers: mfd: Add a driver for iEi WT61P803
 PUZZLE MCU

Hi Luka,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on hwmon/hwmon-next]
[also build test WARNING on v5.9]
[cannot apply to pavel-linux-leds/for-next lee-mfd/for-mfd-next next-20201016]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Luka-Kovacic/Add-support-for-the-iEi-WT61P803-PUZZLE-MCU/20201020-062048
base:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
config: ia64-randconfig-r002-20201020 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/855e7cca9db335136d09555f9983d7245fca1f4b
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Luka-Kovacic/Add-support-for-the-iEi-WT61P803-PUZZLE-MCU/20201020-062048
        git checkout 855e7cca9db335136d09555f9983d7245fca1f4b
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/mfd/iei-wt61p803-puzzle.c:311:5: warning: no previous prototype for 'iei_wt61p803_puzzle_buzzer' [-Wmissing-prototypes]
     311 | int iei_wt61p803_puzzle_buzzer(struct iei_wt61p803_puzzle *mcu, bool long_beep)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/iei_wt61p803_puzzle_buzzer +311 drivers/mfd/iei-wt61p803-puzzle.c

   310	
 > 311	int iei_wt61p803_puzzle_buzzer(struct iei_wt61p803_puzzle *mcu, bool long_beep)
   312	{
   313		unsigned char *resp_buf = mcu->response_buffer;
   314		unsigned char buzzer_cmd[4] = {};
   315		size_t reply_size = 0;
   316		int ret;
   317	
   318		buzzer_cmd[0] = IEI_WT61P803_PUZZLE_CMD_HEADER_START;
   319		buzzer_cmd[1] = IEI_WT61P803_PUZZLE_CMD_FUNCTION_SINGLE;
   320		buzzer_cmd[2] = long_beep ? '3' : '2'; /* Buzzer 1.5 / 0.5 second beep */
   321	
   322		mutex_lock(&mcu->lock);
   323		ret = iei_wt61p803_puzzle_write_command(mcu, buzzer_cmd, sizeof(buzzer_cmd),
   324							resp_buf, &reply_size);
   325		if (ret)
   326			goto exit;
   327	
   328		if (reply_size != 3) {
   329			ret = -EIO;
   330			goto exit;
   331		}
   332	
   333		if (!(resp_buf[0] == IEI_WT61P803_PUZZLE_CMD_HEADER_START &&
   334		      resp_buf[1] == IEI_WT61P803_PUZZLE_CMD_RESPONSE_OK &&
   335		      resp_buf[2] == IEI_WT61P803_PUZZLE_CHECKSUM_RESPONSE_OK)) {
   336			ret = -EPROTO;
   337			goto exit;
   338		}
   339	exit:
   340		mutex_unlock(&mcu->lock);
   341		return ret;
   342	}
   343	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (29543 bytes)