linux-kernel - Re: [PATCH] can: isotp: make const array static, makes object smaller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 20 Oct 2020 17:52:32 +0200
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Colin King <colin.king@...onical.com>,
        Oliver Hartkopp <socketcan@...tkopp.net>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, linux-can@...r.kernel.org,
        netdev@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] can: isotp: make const array static, makes object smaller

On 10/20/20 5:42 PM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Don't populate the const array plen on the stack but instead it
> static. Makes the object code smaller by 926 bytes.
> 
> Before:
>    text	   data	    bss	    dec	    hex	filename
>   26531	   1943	     64	  28538	   6f7a	net/can/isotp.o
> 
> After:
>    text	   data	    bss	    dec	    hex	filename
>   25509	   2039	     64	  27612	   6bdc	net/can/isotp.o
> 
> (gcc version 10.2.0)
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

applied to linux-can/testing.

Thanks,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)